Add support for allowing an embedder to get the V8 profile timer event logs.

src/log.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 81 matching lines @@
   } while (false)
 
 #define LOG_CODE_EVENT(isolate, Call)               \
   do {                                              \
     v8::internal::Logger* logger =                  \
         (isolate)->logger();                        \
     if (logger->is_logging_code_events())           \
       logger->Call;                                 \
   } while (false)
 
+#define LOG_EVENT_BEGIN(isolate, name)              \
+  if ((isolate)->event_logger())                    \
+    (isolate)->event_logger()(name, 0)

[Sven Panne, 2014/03/05 07:47:29]

Parenthesize "name" and never ever use unbalanced "if"s in macros.
Alternatively: Why don't we just use an inline function instead of the macro?
This would be nicer...

[Yang, 2014/03/05 08:18:31]

Agree.

[fmeawad, 2014/03/06 00:24:46]

Moved to an inlined function in Patch 5, and totally removed in Patch 6.

+
+#define LOG_EVENT_END(isolate, name)                \
+  if ((isolate)->event_logger())                    \
+    (isolate)->event_logger()(name, 1)
 
 #define LOG_EVENTS_AND_TAGS_LIST(V)                                     \
   V(CODE_CREATION_EVENT,            "code-creation")                    \
   V(CODE_MOVE_EVENT,                "code-move")                        \
   V(CODE_DELETE_EVENT,              "code-delete")                      \
   V(CODE_MOVING_GC,                 "code-moving-gc")                   \
   V(SHARED_FUNC_MOVE_EVENT,         "sfi-move")                         \
   V(SNAPSHOT_POSITION_EVENT,        "snapshot-pos")                     \
   V(SNAPSHOT_CODE_NAME_EVENT,       "snapshot-code-name")               \
   V(TICK_EVENT,                     "tick")                             \
@@ skipping 201 matching lines @@
 
   void TimerEvent(StartEnd se, const char* name);
 
   static void EnterExternal(Isolate* isolate);
   static void LeaveExternal(Isolate* isolate);
 
   class TimerEventScope {
    public:
     TimerEventScope(Isolate* isolate, const char* name)
         : isolate_(isolate), name_(name) {
-      if (FLAG_log_internal_timer_events) LogTimerEvent(START);
+      LogTimerEvent(START);

[Yang, 2014/03/05 08:18:31]

I'm concerned that this may regress performance since we call LogTimerEvent
(which is not inlined) even if the flag is off.

[fmeawad, 2014/03/06 00:24:46]

As you mentioned, I am only including those for the
Flag_log_internal_timer_events, which should not have a measurable overhead (I
am also excluding it from External).

     }
 
     ~TimerEventScope() {
-      if (FLAG_log_internal_timer_events) LogTimerEvent(END);
+      LogTimerEvent(END);
     }
 
     void LogTimerEvent(StartEnd se);
 
     static const char* v8_recompile_synchronous;
     static const char* v8_recompile_concurrent;
     static const char* v8_compile_full_code;
     static const char* v8_execute;
     static const char* v8_external;
 
@@ skipping 199 matching lines @@
                                  int length) = 0;
 
   NameBuffer* name_buffer_;
 };
 
 
 } }  // namespace v8::internal
 
 
 #endif  // V8_LOG_H_