Add support for allowing an embedder to get the V8 profile timer event logs.

src/v8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 33 matching lines @@
 #include "once.h"
 #include "platform.h"
 #include "sampler.h"
 #include "runtime-profiler.h"
 #include "serialize.h"
 #include "store-buffer.h"
 
 namespace v8 {
 namespace internal {
 
+static void empty_log_internal_events(const char* name, int se) { return; }

[Yang, 2014/03/06 12:05:33]

I think we can remove that return statement too. just an empty { } should be
fine.

[fmeawad, 2014/03/06 19:23:04]

Done.

+
+static void log_internal_events(const char* name, int se) {
+  Isolate* isolate = Isolate::Current();
+  LOG(isolate, Logger::TimerEvent(static_cast<Logger::StartEnd>(se), name));
+}
+
 V8_DECLARE_ONCE(init_once);
 
 List<CallCompletedCallback>* V8::call_completed_callbacks_ = NULL;
 v8::ArrayBuffer::Allocator* V8::array_buffer_allocator_ = NULL;
 v8::Platform* V8::platform_ = NULL;
 
 
 bool V8::Initialize(Deserializer* des) {
   InitializeOncePerProcess();
 
   // The current thread may not yet had entered an isolate to run.
   // Note the Isolate::Current() may be non-null because for various
   // initialization purposes an initializing thread may be assigned an isolate
   // but not actually enter it.
   if (i::Isolate::CurrentPerIsolateThreadData() == NULL) {
     i::Isolate::EnterDefaultIsolate();
   }
 
   ASSERT(i::Isolate::CurrentPerIsolateThreadData() != NULL);
   ASSERT(i::Isolate::CurrentPerIsolateThreadData()->thread_id().Equals(
            i::ThreadId::Current()));
   ASSERT(i::Isolate::CurrentPerIsolateThreadData()->isolate() ==
          i::Isolate::Current());
 
   Isolate* isolate = Isolate::Current();
   if (isolate->IsDead()) return false;
   if (isolate->IsInitialized()) return true;
 
+  if (!isolate->event_logger() && FLAG_log_internal_timer_events) {
+    isolate->set_event_logger(log_internal_events);
+  } else {
+    isolate->set_event_logger(empty_log_internal_events);
+  }

[Yang, 2014/03/06 12:05:33]

I think this should be put into Isolate::Init. And I think the callbacks should
be moved to log.h.

[fmeawad, 2014/03/06 19:23:04]

Done.

+
 #ifdef V8_USE_DEFAULT_PLATFORM
   DefaultPlatform* platform = static_cast<DefaultPlatform*>(platform_);
   platform->SetThreadPoolSize(isolate->max_available_threads());
   // We currently only start the threads early, if we know that we'll use them.
   if (FLAG_job_based_sweeping) platform->EnsureInitialized();
 #endif
 
   return isolate->Init(des);
 }
 
@@ skipping 140 matching lines @@
   platform_ = NULL;
 }
 
 
 v8::Platform* V8::GetCurrentPlatform() {
   ASSERT(platform_);
   return platform_;
 }
 
 } }  // namespace v8::internal