Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1861603003: Remove WTF_LOG(FileAPI,...) (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
tkent, jianli
CC:
blink-reviews, chromium-reviews, kinuko+watch, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WTF_LOG(FileAPI,...) Replace logging with DVLOG(1). I chose DVLOG since it seems a little odd that arbirtary data would be logged to the system log and we can save binary size with DVLOG. BUG=596760 Committed: https://crrev.com/4f18776c132b68a9be0541c730b72cb3806171bd Cr-Commit-Position: refs/heads/master@{#385950}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 7 chunks +5 lines, -7 lines 1 comment Download
M third_party/WebKit/Source/platform/Logging.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Logging.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
dtapuska
4 years, 8 months ago (2016-04-05 17:51:15 UTC) #3
dtapuska
On 2016/04/05 17:51:15, dtapuska wrote: jianli@ you were the original author of this code so ...
4 years, 8 months ago (2016-04-05 17:51:51 UTC) #4
jianli
https://codereview.chromium.org/1861603003/diff/1/third_party/WebKit/Source/core/fileapi/FileReader.cpp File third_party/WebKit/Source/core/fileapi/FileReader.cpp (right): https://codereview.chromium.org/1861603003/diff/1/third_party/WebKit/Source/core/fileapi/FileReader.cpp#newcode54 third_party/WebKit/Source/core/fileapi/FileReader.cpp:54: const CString utf8BlobUUID(Blob* blob) Will these 2 functions be ...
4 years, 8 months ago (2016-04-06 20:06:07 UTC) #5
dtapuska
On 2016/04/06 20:06:07, jianli wrote: > https://codereview.chromium.org/1861603003/diff/1/third_party/WebKit/Source/core/fileapi/FileReader.cpp > File third_party/WebKit/Source/core/fileapi/FileReader.cpp (right): > > https://codereview.chromium.org/1861603003/diff/1/third_party/WebKit/Source/core/fileapi/FileReader.cpp#newcode54 > ...
4 years, 8 months ago (2016-04-06 20:30:34 UTC) #6
jianli
lgtm
4 years, 8 months ago (2016-04-07 20:58:14 UTC) #7
tkent
lgtm
4 years, 8 months ago (2016-04-07 23:07:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861603003/1
4 years, 8 months ago (2016-04-07 23:21:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 02:56:24 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 02:58:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f18776c132b68a9be0541c730b72cb3806171bd
Cr-Commit-Position: refs/heads/master@{#385950}

Powered by Google App Engine
This is Rietveld 408576698