Remove WTF_LOG(FileAPI,...)

Remove WTF_LOG(FileAPI,...)

Replace logging with DVLOG(1). I chose DVLOG since
it seems a little odd that arbirtary data would be logged
to the system log and we can save binary size with DVLOG.

BUG=596760
Committed: https://crrev.com/4f18776c132b68a9be0541c730b72cb3806171bd
Cr-Commit-Position: refs/heads/master@{#385950}

[dtapuska, 2016-04-05 16:25:31]

Description was changed from

==========
Remove WTF_LOG(FileAPI,...)

Replace logging with DVLOG(1). I chose DVLOG since
it seems a little odd that arbirtary data would be logged
to the system log.

BUG=596760
==========

to

==========
Remove WTF_LOG(FileAPI,...)

Replace logging with DVLOG(1). I chose DVLOG since
it seems a little odd that arbirtary data would be logged
to the system log and we can save binary size with DVLOG.

BUG=596760
==========

[dtapuska, 2016-04-05 16:28:54]

dtapuska@chromium.org changed reviewers:
+ jianli@chromium.org, tkent@chromium.org

[dtapuska, 2016-04-05 17:51:51]

On 2016/04/05 17:51:15, dtapuska wrote:

jianli@ you were the original author of this code so I thought I'd get your
opinion on the DVLOG vs VLOG.

[jianli, 2016-04-06 20:06:07]

https://codereview.chromium.org/1861603003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fileapi/FileReader.cpp (right):

https://codereview.chromium.org/1861603003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fileapi/FileReader.cpp:54: const CString
utf8BlobUUID(Blob* blob)
Will these 2 functions be included in release build?

[dtapuska, 2016-04-06 20:30:34]

On 2016/04/06 20:06:07, jianli wrote:
>
https://codereview.chromium.org/1861603003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/fileapi/FileReader.cpp (right):
> 
>
https://codereview.chromium.org/1861603003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/fileapi/FileReader.cpp:54: const CString
> utf8BlobUUID(Blob* blob)
> Will these 2 functions be included in release build?

They should get optimized out since they are in the anonymous namespace. I
verified changing DVLOG(..) to VLOG(..) decreases the binary size of the so;
although I didn't look for those symbols in the so.

[jianli, 2016-04-07 20:58:14]

lgtm

[tkent, 2016-04-07 23:07:26]

lgtm

[dtapuska, 2016-04-07 23:20:53]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-04-07 23:21:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861603003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861603003/1

[commit-bot: I haz the power, 2016-04-08 02:56:23]

Description was changed from

==========
Remove WTF_LOG(FileAPI,...)

Replace logging with DVLOG(1). I chose DVLOG since
it seems a little odd that arbirtary data would be logged
to the system log and we can save binary size with DVLOG.

BUG=596760
==========

to

==========
Remove WTF_LOG(FileAPI,...)

Replace logging with DVLOG(1). I chose DVLOG since
it seems a little odd that arbirtary data would be logged
to the system log and we can save binary size with DVLOG.

BUG=596760
==========

[commit-bot: I haz the power, 2016-04-08 02:56:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-08 02:58:42]

Description was changed from

==========
Remove WTF_LOG(FileAPI,...)

Replace logging with DVLOG(1). I chose DVLOG since
it seems a little odd that arbirtary data would be logged
to the system log and we can save binary size with DVLOG.

BUG=596760
==========

to

==========
Remove WTF_LOG(FileAPI,...)

Replace logging with DVLOG(1). I chose DVLOG since
it seems a little odd that arbirtary data would be logged
to the system log and we can save binary size with DVLOG.

BUG=596760

Committed: https://crrev.com/4f18776c132b68a9be0541c730b72cb3806171bd
Cr-Commit-Position: refs/heads/master@{#385950}
==========

[commit-bot: I haz the power, 2016-04-08 02:58:43]

Patchset 1 (id:??) landed as
https://crrev.com/4f18776c132b68a9be0541c730b72cb3806171bd
Cr-Commit-Position: refs/heads/master@{#385950}