Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1861583002: [frames] Also properly deal with TF builtins in OptimizedFrame::GetFunctions(). (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[frames] Also properly deal with TF builtins in OptimizedFrame::GetFunctions(). This was missing from the previous fix. R=ishell@chromium.org BUG=chromium:599714 LOG=n Committed: https://crrev.com/e5724d958bdca95ec92c19060da88c895fca97e8 Cr-Commit-Position: refs/heads/master@{#35249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M src/frames.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-599714.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-05 04:26:41 UTC) #1
Benedikt Meurer
Hey Igor, Quick fix. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-04-05 04:27:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861583002/1
4 years, 8 months ago (2016-04-05 04:43:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 06:18:03 UTC) #6
Igor Sheludko
lgtm
4 years, 8 months ago (2016-04-05 06:38:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861583002/1
4 years, 8 months ago (2016-04-05 06:39:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 06:41:07 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 06:41:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5724d958bdca95ec92c19060da88c895fca97e8
Cr-Commit-Position: refs/heads/master@{#35249}

Powered by Google App Engine
This is Rietveld 408576698