Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: content/common/gpu/media/dxva_video_decode_accelerator_win.cc

Issue 1861483004: Ensure that the open gl context is current in the DXVA decoder while processing configuration chang… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/media/dxva_video_decode_accelerator_win.cc
diff --git a/content/common/gpu/media/dxva_video_decode_accelerator_win.cc b/content/common/gpu/media/dxva_video_decode_accelerator_win.cc
index c15d7db9971a69226dc80ced3b608f63d4c5475c..ac82e28ab68c438e01dbdf63e041d1151c6387c6 100644
--- a/content/common/gpu/media/dxva_video_decode_accelerator_win.cc
+++ b/content/common/gpu/media/dxva_video_decode_accelerator_win.cc
@@ -2832,6 +2832,9 @@ HRESULT DXVAVideoDecodeAccelerator::CheckConfigChanged(
void DXVAVideoDecodeAccelerator::ConfigChanged(
const Config& config) {
DCHECK(main_thread_task_runner_->BelongsToCurrentThread());
+ RETURN_AND_NOTIFY_ON_FAILURE(make_context_current_.Run(),
sandersd (OOO until July 31) 2016/04/04 23:35:46 Should it be Invalidate() and/or Initialize() that
ananta 2016/04/05 00:00:36 In the general case Invalidate and Initialize get
+ "Failed to make context current", PLATFORM_FAILURE, );
+
SetState(kConfigChange);
DismissStaleBuffers(true);
jbauman 2016/04/05 00:02:18 DismissStaleBuffers is called from other places (e
ananta 2016/04/05 00:22:10 Done.
Invalidate();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698