Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1861483004: Ensure that the open gl context is current in the DXVA decoder while processing configuration chang… (Closed)

Created:
4 years, 8 months ago by ananta
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that the open gl context is current in the DXVA decoder while processing configuration changes. This should hopefully fix the DCHECK's which fire for a valid fence when the picture buffers are being torn down. BUG=600323 Committed: https://crrev.com/0f3b2d37a14070c7d17b34053d3b345a844153fd Cr-Commit-Position: refs/heads/master@{#385070}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Make the context current in Invalidate #

Patch Set 3 : Add code to make the gl context current in DismissStaleBuffer and DeferredDismissStaleBuffer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator_win.cc View 1 2 4 chunks +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (3 generated)
ananta
4 years, 8 months ago (2016-04-04 23:33:06 UTC) #2
sandersd (OOO until July 31)
https://codereview.chromium.org/1861483004/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc File content/common/gpu/media/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/1861483004/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc#newcode2835 content/common/gpu/media/dxva_video_decode_accelerator_win.cc:2835: RETURN_AND_NOTIFY_ON_FAILURE(make_context_current_.Run(), Should it be Invalidate() and/or Initialize() that do ...
4 years, 8 months ago (2016-04-04 23:35:46 UTC) #3
ananta
https://codereview.chromium.org/1861483004/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc File content/common/gpu/media/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/1861483004/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc#newcode2835 content/common/gpu/media/dxva_video_decode_accelerator_win.cc:2835: RETURN_AND_NOTIFY_ON_FAILURE(make_context_current_.Run(), On 2016/04/04 23:35:46, sandersd wrote: > Should it ...
4 years, 8 months ago (2016-04-05 00:00:36 UTC) #4
jbauman
https://codereview.chromium.org/1861483004/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc File content/common/gpu/media/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/1861483004/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc#newcode2839 content/common/gpu/media/dxva_video_decode_accelerator_win.cc:2839: DismissStaleBuffers(true); DismissStaleBuffers is called from other places (e.g. directly ...
4 years, 8 months ago (2016-04-05 00:02:18 UTC) #5
ananta
https://codereview.chromium.org/1861483004/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc File content/common/gpu/media/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/1861483004/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc#newcode2839 content/common/gpu/media/dxva_video_decode_accelerator_win.cc:2839: DismissStaleBuffers(true); On 2016/04/05 00:02:18, jbauman wrote: > DismissStaleBuffers is ...
4 years, 8 months ago (2016-04-05 00:22:10 UTC) #6
sandersd (OOO until July 31)
Alright, lgtm.
4 years, 8 months ago (2016-04-05 00:23:21 UTC) #7
jbauman
lgtm
4 years, 8 months ago (2016-04-05 00:32:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861483004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861483004/40001
4 years, 8 months ago (2016-04-05 00:50:48 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-05 01:20:32 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 01:21:43 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0f3b2d37a14070c7d17b34053d3b345a844153fd
Cr-Commit-Position: refs/heads/master@{#385070}

Powered by Google App Engine
This is Rietveld 408576698