Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1861473004: Use 'approx equals' in negative playback rate test (Closed)

Created:
4 years, 8 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 8 months ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use 'approx equals' in negative playback rate test Due to floating point error, some tests in the web-animations-api/ animation-state-changes-negative-playback-rate.html layout test flakily fail. This patch changes some asserts from assert_equals to assert_approx_equals with an epsilon of 0.000001. BUG=593982 Committed: https://crrev.com/313087501309dddbcc94481ee7ef666472079bee Cr-Commit-Position: refs/heads/master@{#385612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
suzyh_UTC10 (ex-contributor)
4 years, 8 months ago (2016-04-06 04:25:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861473004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861473004/1
4 years, 8 months ago (2016-04-06 04:25:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 06:47:17 UTC) #6
dstockwell
lgtm
4 years, 8 months ago (2016-04-07 01:19:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861473004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861473004/1
4 years, 8 months ago (2016-04-07 01:22:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 01:28:29 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 01:29:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/313087501309dddbcc94481ee7ef666472079bee
Cr-Commit-Position: refs/heads/master@{#385612}

Powered by Google App Engine
This is Rietveld 408576698