Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1861453002: Upgrade version of Visual Studio in which cdb.exe is searched for. (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
Reviewers:
nednguyen, scottmg
CC:
catapult-reviews_chromium.org, scottmg, David Yen
Base URL:
https://github.com/kenrussell/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
Ken Russell (switch to Gerrit)
Ned: please review. Thanks. Scott: thanks for catching this error in the earlier CL. Tested ...
4 years, 8 months ago (2016-04-04 21:52:16 UTC) #2
scottmg
lgtm https://codereview.chromium.org/1861453002/diff/1/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py File telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py (right): https://codereview.chromium.org/1861453002/diff/1/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py#newcode188 telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py:188: os.path.join('Windows Kits', '8.0', 'Debuggers', 'x64'), While you're here, ...
4 years, 8 months ago (2016-04-04 21:53:44 UTC) #4
nednguyen
lgtm
4 years, 8 months ago (2016-04-04 21:58:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861453002/1
4 years, 8 months ago (2016-04-04 21:58:10 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 22:11:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698