Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 1861443002: DevTools: [Elements] set non-zero hide timeout timer for image popover (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 this._includeRootDOMNode = !omitRootDOMNode; 66 this._includeRootDOMNode = !omitRootDOMNode;
67 this._selectEnabled = selectEnabled; 67 this._selectEnabled = selectEnabled;
68 /** @type {?WebInspector.DOMNode} */ 68 /** @type {?WebInspector.DOMNode} */
69 this._rootDOMNode = null; 69 this._rootDOMNode = null;
70 /** @type {?WebInspector.DOMNode} */ 70 /** @type {?WebInspector.DOMNode} */
71 this._selectedDOMNode = null; 71 this._selectedDOMNode = null;
72 72
73 this._visible = false; 73 this._visible = false;
74 74
75 this._popoverHelper = new WebInspector.PopoverHelper(this._element, this._ge tPopoverAnchor.bind(this), this._showPopover.bind(this)); 75 this._popoverHelper = new WebInspector.PopoverHelper(this._element, this._ge tPopoverAnchor.bind(this), this._showPopover.bind(this));
76 this._popoverHelper.setTimeout(0); 76 this._popoverHelper.setTimeout(0, 100);
dgozman 2016/04/04 21:49:02 Isn't 100 too short a timeout? Make it 1000 to acc
lushnikov 2016/04/04 22:35:18 You only need it to hover over the popover. The "
77 77
78 /** @type {!Map<!WebInspector.DOMNode, !WebInspector.ElementsTreeOutline.Upd ateRecord>} */ 78 /** @type {!Map<!WebInspector.DOMNode, !WebInspector.ElementsTreeOutline.Upd ateRecord>} */
79 this._updateRecords = new Map(); 79 this._updateRecords = new Map();
80 /** @type {!Set<!WebInspector.ElementsTreeElement>} */ 80 /** @type {!Set<!WebInspector.ElementsTreeElement>} */
81 this._treeElementsBeingUpdated = new Set(); 81 this._treeElementsBeingUpdated = new Set();
82 82
83 this._domModel.addEventListener(WebInspector.DOMModel.Events.MarkersChanged, this._markersChanged, this); 83 this._domModel.addEventListener(WebInspector.DOMModel.Events.MarkersChanged, this._markersChanged, this);
84 } 84 }
85 85
86 /** @typedef {{node: !WebInspector.DOMNode, isCut: boolean}} */ 86 /** @typedef {{node: !WebInspector.DOMNode, isCut: boolean}} */
(...skipping 1697 matching lines...) Expand 10 before | Expand all | Expand 10 after
1784 if (node) { 1784 if (node) {
1785 this.treeOutline._selectedDOMNode = node; 1785 this.treeOutline._selectedDOMNode = node;
1786 this.treeOutline._selectedNodeChanged(); 1786 this.treeOutline._selectedNodeChanged();
1787 } 1787 }
1788 } 1788 }
1789 return true; 1789 return true;
1790 }, 1790 },
1791 1791
1792 __proto__: TreeElement.prototype 1792 __proto__: TreeElement.prototype
1793 } 1793 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698