Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1861443002: DevTools: [Elements] set non-zero hide timeout timer for image popover (Closed)

Created:
4 years, 8 months ago by lushnikov
Modified:
4 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Elements] set non-zero hide timeout timer for image popover The non-zero hide timeout makes it possible to hover over popover and copy some useful information from it. BUG=599592 R=dgozman, pfeldman Committed: https://crrev.com/d217d6f3d6fd76f78b153ee1de31557a353168e8 Cr-Commit-Position: refs/heads/master@{#385048}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 12 (4 generated)
lushnikov
pta
4 years, 8 months ago (2016-04-04 21:37:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861443002/1
4 years, 8 months ago (2016-04-04 21:38:42 UTC) #3
dgozman
lgtm https://codereview.chromium.org/1861443002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js (right): https://codereview.chromium.org/1861443002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js#newcode76 third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js:76: this._popoverHelper.setTimeout(0, 100); Isn't 100 too short a timeout? ...
4 years, 8 months ago (2016-04-04 21:49:02 UTC) #4
lushnikov
https://codereview.chromium.org/1861443002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js (right): https://codereview.chromium.org/1861443002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js#newcode76 third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js:76: this._popoverHelper.setTimeout(0, 100); On 2016/04/04 21:49:02, dgozman wrote: > Isn't ...
4 years, 8 months ago (2016-04-04 22:35:19 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 23:14:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861443002/1
4 years, 8 months ago (2016-04-04 23:15:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 23:23:13 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 23:24:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d217d6f3d6fd76f78b153ee1de31557a353168e8
Cr-Commit-Position: refs/heads/master@{#385048}

Powered by Google App Engine
This is Rietveld 408576698