third_party/WebKit/Source/bindings/templates/constants.cpp - Issue 1861433002: Make [OriginTrialEnabled] and [RuntimeEnabled] mutually exclusive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/constants.cpp

Issue 1861433002: Make [OriginTrialEnabled] and [RuntimeEnabled] mutually exclusive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@586594-separate-tests

Patch Set: Clean up commented code Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/v8_utilities.py ('K') | « third_party/WebKit/Source/bindings/templates/attributes.cpp ('k') | third_party/WebKit/Source/bindings/templates/methods.cpp » ('j') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/constants.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/constants.cpp b/third_party/WebKit/Source/bindings/templates/constants.cpp

index 6a9cef4d38b374932fbfa23441678cf78376b779..290da971de1ac5ad02210aff1c81a606b72063e7 100644

--- a/third_party/WebKit/Source/bindings/templates/constants.cpp

+++ b/third_party/WebKit/Source/bindings/templates/constants.cpp

@@ -10,7 +10,7 @@ static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v

{% if constant.measure_as %}

UseCounter::countIfNotPrivateScript(info.GetIsolate(), currentExecutionContext(info.GetIsolate()), UseCounter::{{constant.measure_as('ConstantGetter')}});

{% endif %}

- {% if constant.is_origin_trial_enabled %}

+ {% if constant.origin_trial_enabled %}

{% endif %}

{% if constant.idl_type in ('Double', 'Float') %}