Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1861403002: Rename FX_SAFE_DWORD to FX_SAFE_UINT32 (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename FX_SAFE_DWORD to FX_SAFE_UINT32 We removed the FX_DWORD typedef in favour of uint32_t. This CL cleans up the FX_SAFE_DWORD naming to match. BUG=pdfium:81, pdfium:470 Committed: https://pdfium.googlesource.com/pdfium/+/4e20094dbb2ea942734b8986fa9a60d2f3ccbb1b

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -107 lines) Patch
M core/fdrm/crypto/fx_crypt.cpp View 1 3 chunks +24 lines, -24 lines 0 comments Download
M core/fdrm/crypto/fx_crypt_sha.cpp View 1 6 chunks +47 lines, -47 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_func.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp View 9 chunks +12 lines, -11 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M core/fxcodec/codec/fx_codec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_jpeg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_Image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/include/fx_safe_types.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-06 16:08:33 UTC) #2
Tom Sepez
On 2016/04/06 16:08:33, dsinclair wrote: > PTAL. There's also GET_FX_DWORD and PUT_FX_DWORD lurking in core/fdrm/crypto/*.cpp ...
4 years, 8 months ago (2016-04-06 16:45:44 UTC) #3
dsinclair
PTAL. Added the crypto changes.
4 years, 8 months ago (2016-04-06 17:04:19 UTC) #4
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-06 19:03:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861403002/20001
4 years, 8 months ago (2016-04-06 19:06:18 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 19:06:40 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/4e20094dbb2ea942734b8986fa9a60d2f3cc...

Powered by Google App Engine
This is Rietveld 408576698