components/update_client/update_response.cc - Issue 1861383004: Add module for counting date-last-roll-call and persisting those counts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/update_response.cc

Issue 1861383004: Add module for counting date-last-roll-call and persisting those counts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another test fix. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/update_client/update_response.h ('k') | ios/chrome/browser/component_updater/ios_component_updater_configurator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/update_client/update_response.cc

diff --git a/components/update_client/update_response.cc b/components/update_client/update_response.cc

index bdf77f822a5c493264737cacaa79497c25804e14..3d8d14d5305d83b7547b95b558915066ec67896a 100644

--- a/components/update_client/update_response.cc

+++ b/components/update_client/update_response.cc

@@ -287,6 +287,7 @@ bool ParseAppTag(xmlNode* app,

bool UpdateResponse::Parse(const std::string& response_xml) {

results_.daystart_elapsed_seconds = kNoDaystart;

+ results_.daystart_elapsed_days = kNoDaystart;

results_.list.clear();

errors_.clear();

@@ -335,6 +336,11 @@ bool UpdateResponse::Parse(const std::string& response_xml) {

if (base::StringToInt(elapsed_seconds, &parsed_elapsed)) {

results_.daystart_elapsed_seconds = parsed_elapsed;

}

+ std::string elapsed_days = GetAttribute(first, "elapsed_days");

+ parsed_elapsed = kNoDaystart;

+ if (base::StringToInt(elapsed_days, &parsed_elapsed)) {

+ results_.daystart_elapsed_days = parsed_elapsed;

+ }

}

// Parse each of the <app> tags.