Add module for counting date-last-roll-call and persisting those counts

components/update_client/persisted_data_unittest.cc

Index: components/update_client/persisted_data_unittest.cc
diff --git a/components/update_client/persisted_data_unittest.cc b/components/update_client/persisted_data_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..66694ace25556c1060a10e9c52f910336da06934
--- /dev/null
+++ b/components/update_client/persisted_data_unittest.cc
@@ -0,0 +1,60 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+#include <vector>
+
+#include "components/prefs/testing_pref_service.h"
+#include "components/update_client/persisted_data.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace update_client {
+
+class PersistedDataTest : public testing::Test {

[Bernhard Bauer, 2016/04/08 09:06:10]

You don't need to add an empty test fixture. Just use the TEST macro instead of
TEST_F, which creates a test without a fixture.

[waffles, 2016/04/08 19:11:01]

Done.

+ public:
+  PersistedDataTest();
+  ~PersistedDataTest() override;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(PersistedDataTest);
+};
+
+PersistedDataTest::PersistedDataTest() {
+}
+
+PersistedDataTest::~PersistedDataTest() {
+}
+
+TEST_F(PersistedDataTest, Simple) {
+  scoped_ptr<TestingPrefServiceSimple> pref(new TestingPrefServiceSimple());

[Bernhard Bauer, 2016/04/08 09:06:10]

Nit: scoped_ptr<> is deprecated now! 😃 Use std::unique_ptr<> instead.

[waffles, 2016/04/08 19:11:01]

Done.

+  RegisterPersistedDataPreferences(pref->registry());
+  scoped_refptr<PersistedData> metadata(new PersistedData(pref.get()));
+  EXPECT_EQ(-2, metadata->DateLastRollCall("someappid"));
+  std::vector<std::string> items;
+  items.push_back("someappid");
+  metadata->SetDateLastRollCall(items, 3383);
+  EXPECT_EQ(3383, metadata->DateLastRollCall("someappid"));
+  EXPECT_EQ(-2, metadata->DateLastRollCall("someotherappid"));
+  metadata->SetDateLastRollCall(items, 3386);
+  EXPECT_EQ(3386, metadata->DateLastRollCall("someappid"));
+  EXPECT_EQ(-2, metadata->DateLastRollCall("someotherappid"));
+}
+
+TEST_F(PersistedDataTest, SharedPref) {
+  scoped_ptr<TestingPrefServiceSimple> pref(new TestingPrefServiceSimple());
+  RegisterPersistedDataPreferences(pref->registry());
+  scoped_refptr<PersistedData> metadata(new PersistedData(pref.get()));
+  EXPECT_EQ(-2, metadata->DateLastRollCall("someappid"));
+  std::vector<std::string> items;
+  items.push_back("someappid");
+  metadata->SetDateLastRollCall(items, 3383);
+
+  // Now, create a new PersistedData reading from the same path, verify
+  // that it loads the value.
+  metadata = new PersistedData(pref.get());
+  EXPECT_EQ(3383, metadata->DateLastRollCall("someappid"));
+  EXPECT_EQ(-2, metadata->DateLastRollCall("someotherappid"));
+}
+
+}  // namespace update_client