Add module for counting date-last-roll-call and persisting those counts

components/update_client/component_metadata_unittest.cc

Index: components/update_client/component_metadata_unittest.cc
diff --git a/components/update_client/component_metadata_unittest.cc b/components/update_client/component_metadata_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1bf1995fad597c364a2b8a6295930f1bf14a1449
--- /dev/null
+++ b/components/update_client/component_metadata_unittest.cc
@@ -0,0 +1,80 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+#include <vector>
+
+#include "base/files/file_path.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/run_loop.h"
+#include "base/thread_task_runner_handle.h"
+#include "components/update_client/component_metadata.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace update_client {
+
+class ComponentMetadataTest : public testing::Test {
+ public:
+  ComponentMetadataTest();
+  ~ComponentMetadataTest() override;
+
+  // Overrides from testing::Test.
+  void SetUp() override;
+
+ protected:
+  scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
+
+ private:
+  base::MessageLoopForIO used_for_threadtaskrunnerhandle_;

[Sorin Jianu, 2016/04/07 04:03:19]

Do we need base::MessageLoopForIO? I think we've been using this for tests that
use the network.

[waffles, 2016/04/07 17:04:44]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(ComponentMetadataTest);
+};
+
+void ComponentMetadataTest::SetUp() {
+  task_runner_ = base::ThreadTaskRunnerHandle::Get();

[Sorin Jianu, 2016/04/07 04:03:19]

why not directly initialize in the ctor?

[waffles, 2016/04/07 17:04:44]

Done. (Removed it as a class member, put it in the tests directly.)

+}
+
+ComponentMetadataTest::ComponentMetadataTest() {
+}
+
+ComponentMetadataTest::~ComponentMetadataTest() {
+}
+
+TEST_F(ComponentMetadataTest, InMemory) {
+  scoped_refptr<ComponentMetadata> metadata(new ComponentMetadata(
+      base::FilePath(), task_runner_));
+  base::RunLoop().RunUntilIdle();  // To let Initialize() finish.
+  EXPECT_EQ(-2, metadata->DateLastRollCall("someappid"));
+  std::vector<std::string> items;
+  items.push_back("someappid");
+  metadata->SetDateLastRollCall(items, 3383);
+  EXPECT_EQ(3383, metadata->DateLastRollCall("someappid"));
+  EXPECT_EQ(-2, metadata->DateLastRollCall("someotherappid"));
+  metadata->SetDateLastRollCall(items, 3386);
+  EXPECT_EQ(3386, metadata->DateLastRollCall("someappid"));
+  EXPECT_EQ(-2, metadata->DateLastRollCall("someotherappid"));
+}
+
+TEST_F(ComponentMetadataTest, InFile) {
+  base::ScopedTempDir dir;
+  EXPECT_TRUE(dir.CreateUniqueTempDir());
+  base::FilePath path = dir.path().AppendASCII("t.json");
+  scoped_refptr<ComponentMetadata> metadata(new ComponentMetadata(
+      path, task_runner_));
+  base::RunLoop().RunUntilIdle();  // To let Initialize() finish.
+  EXPECT_EQ(-2, metadata->DateLastRollCall("someappid"));
+  std::vector<std::string> items;
+  items.push_back("someappid");
+  metadata->SetDateLastRollCall(items, 3383);
+  base::RunLoop().RunUntilIdle();
+
+  // Now, create a new ComponentMetadata reading from the same path, verify
+  // that it loads the value.
+  metadata = new ComponentMetadata(path, task_runner_);
+  base::RunLoop().RunUntilIdle();  // To let Initialize() finish.
+  EXPECT_EQ(3383, metadata->DateLastRollCall("someappid"));
+  EXPECT_EQ(-2, metadata->DateLastRollCall("someotherappid"));
+}
+
+}  // namespace update_client