Add TaskManagerEndProcessEnabled policy

Add TaskManagerEndProcessEnabled policy, which enables or disables killing a process from Chromium's Task Manager.

End process button in task manager is disabled when policy is set to
false. If the policy is not set or set to true, killing a process is possible.

BUG=590480
Committed: https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c
Cr-Commit-Position: refs/heads/master@{#388373}

[Andrew T Wilson (Slow), 2016-04-07 08:09:28]

atwilson@chromium.org changed reviewers:
+ atwilson@chromium.org

[Andrew T Wilson (Slow), 2016-04-07 08:09:29]

Mostly LG, although tests are failing. Let's chat about the behavior you were
seeing yesterday to see if it's correct.

https://codereview.chromium.org/1861383002/diff/1/components/policy/resources...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1861383002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:8472: 'dynamic_refresh':
False,
dynamic_refresh should be True, because you can change this policy on the fly
without having to restart the browser.

https://codereview.chromium.org/1861383002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:8473: 'per_profile': True,
per_profile should be false, because you are only able to set this globally
across all users (since the task manager is a per-browser UI, not per-user).

[Marton Hunyady, 2016-04-07 11:54:32]

https://codereview.chromium.org/1861383002/diff/1/components/policy/resources...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1861383002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:8472: 'dynamic_refresh':
False,
On 2016/04/07 08:09:29, Andrew T Wilson (Slow) wrote:
> dynamic_refresh should be True, because you can change this policy on the fly
> without having to restart the browser.

Done.

https://codereview.chromium.org/1861383002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:8473: 'per_profile': True,
On 2016/04/07 08:09:29, Andrew T Wilson (Slow) wrote:
> per_profile should be false, because you are only able to set this globally
> across all users (since the task manager is a per-browser UI, not per-user).

Done.

[Marton Hunyady, 2016-04-07 11:54:32]

https://codereview.chromium.org/1861383002/diff/1/components/policy/resources...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1861383002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:8472: 'dynamic_refresh':
False,
On 2016/04/07 08:09:29, Andrew T Wilson (Slow) wrote:
> dynamic_refresh should be True, because you can change this policy on the fly
> without having to restart the browser.

Done.

https://codereview.chromium.org/1861383002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:8473: 'per_profile': True,
On 2016/04/07 08:09:29, Andrew T Wilson (Slow) wrote:
> per_profile should be false, because you are only able to set this globally
> across all users (since the task manager is a per-browser UI, not per-user).

Done.

[Andrew T Wilson (Slow), 2016-04-08 15:50:27]

lgtm

https://codereview.chromium.org/1861383002/diff/60001/components/policy/resou...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1861383002/diff/60001/components/policy/resou...
components/policy/resources/policy_templates.json:8470: 'supported_on':
['chrome.*:51-','chrome_os:51-'],
BTW, if this CL can land before the branch, great, otherwise you'll need to go
back and change this to 52, not 51.

[Marton Hunyady, 2016-04-08 17:01:08]

The CQ bit was checked by hunyadym@chromium.org

[commit-bot: I haz the power, 2016-04-08 17:01:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861383002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861383002/60001

[commit-bot: I haz the power, 2016-04-08 17:12:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 17:12:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Marton Hunyady, 2016-04-19 01:07:33]

hunyadym@chromium.org changed reviewers:
+ asvitkine@chromium.org, isherman@chromium.org, msw@chromium.org,
nick@chromium.org

[Marton Hunyady, 2016-04-19 01:07:34]

isherman: PTAL at histograms.xml
asvitkine: PTAL at chrome/browser/ui/cocoa/task_manager_mac.mm
msw: PTAL at chrome/browser/ui/views/*
nick: PTAL at chrome/browser/task_manager/*

Thanks!

[Ilya Sherman, 2016-04-19 01:48:30]

histograms.xml lgtm

[Alexei Svitkine (slow), 2016-04-19 14:41:08]

lgtm

[msw, 2016-04-19 17:40:20]

c/b/ui/views lgtm
(I posted to http://crbug.com/528486 about the two views UI impls)

[ncarter (slow), 2016-04-19 18:28:58]

lgtm

[ncarter (slow), 2016-04-19 18:30:15]

Please update the title/description to reflect that this is a behavior change,
not just a test change.

Something like: "Add a preference to disable the task killing button in the Task
Manager"

[Marton Hunyady, 2016-04-19 23:43:05]

Description was changed from

==========
Add TaskManagerEndProcessEnabled policy to policy_test_cases.json

End process button in task manager is disabled when policy is set to
false.

BUG=590480
==========

to

==========
Add TaskManagerEndProcessEnabled policy, which enables or disables killing a
process from Chromium's Task Manager.

End process button in task manager is disabled when policy is set to
false. If the policy is not set or set to true, killing a process is possible.

BUG=590480
==========

[Marton Hunyady, 2016-04-19 23:45:22]

The CQ bit was checked by hunyadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 23:45:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861383002/80001

[commit-bot: I haz the power, 2016-04-20 00:15:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 00:16:01]

Dry run: This issue passed the CQ dry run.

[Marton Hunyady, 2016-04-20 00:18:30]

The CQ bit was checked by hunyadym@chromium.org

[Marton Hunyady, 2016-04-20 00:18:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/1861383002/#ps80001
(title: "Update supported_on to 52")

[commit-bot: I haz the power, 2016-04-20 00:18:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861383002/80001

[commit-bot: I haz the power, 2016-04-20 00:23:55]

Description was changed from

==========
Add TaskManagerEndProcessEnabled policy, which enables or disables killing a
process from Chromium's Task Manager.

End process button in task manager is disabled when policy is set to
false. If the policy is not set or set to true, killing a process is possible.

BUG=590480
==========

to

==========
Add TaskManagerEndProcessEnabled policy, which enables or disables killing a
process from Chromium's Task Manager.

End process button in task manager is disabled when policy is set to
false. If the policy is not set or set to true, killing a process is possible.

BUG=590480
==========

[commit-bot: I haz the power, 2016-04-20 00:23:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-22 19:18:45]

Description was changed from

==========
Add TaskManagerEndProcessEnabled policy, which enables or disables killing a
process from Chromium's Task Manager.

End process button in task manager is disabled when policy is set to
false. If the policy is not set or set to true, killing a process is possible.

BUG=590480
==========

to

==========
Add TaskManagerEndProcessEnabled policy, which enables or disables killing a
process from Chromium's Task Manager.

End process button in task manager is disabled when policy is set to
false. If the policy is not set or set to true, killing a process is possible.

BUG=590480

Committed: https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c
Cr-Commit-Position: refs/heads/master@{#388373}
==========

[commit-bot: I haz the power, 2016-04-22 19:18:46]

Patchset 5 (id:??) landed as
https://crrev.com/e7a3229d4266db4286ede951643303b1f735023c
Cr-Commit-Position: refs/heads/master@{#388373}

[Thiemo Nagel, 2016-04-25 14:16:28]

tnagel@chromium.org changed reviewers:
+ tnagel@chromium.org

[Thiemo Nagel, 2016-04-25 14:16:30]

https://codereview.chromium.org/1861383002/diff/80001/components/policy/resou...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1861383002/diff/80001/components/policy/resou...
components/policy/resources/policy_templates.json:8463: 'desc': '''Enables
ending processes in <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph>'s 
Task Manager.
There's a duplicate blank before "Task Manager".

[Marton Hunyady, 2016-04-26 16:06:58]

Patchset #6 (id:100001) has been deleted

[scottmg, 2016-04-26 19:50:36]

I'm getting build failure that seems related to this change on a relatively
clean tree, using the GN Windows build.

[13795->2/13830 ~33] CXX obj/components/policy/policy/policy_constants.obj
FAILED: ninja -t msvc -e environment.x86 --
"d:\src\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC @obj/components/policy/policy/policy_constants.obj.rsp
/c gen/policy/policy_constants.cc
/Foobj/components/policy/policy/policy_constants.obj
/Fd"obj/components/policy/policy_cc.pdb"
d:\src\cr3\src\out\debug\gen\policy\policy_constants.cc(772): error C2039:
'kTaskManagerEndProcessEnabled': is not a member of 'policy::key'
d:\src\cr3\src\out\debug\gen\policy\policy\policy_constants.h(37): note: see
declaration of 'policy::key'
d:\src\cr3\src\out\debug\gen\policy\policy_constants.cc(772): error C2065:
'kTaskManagerEndProcessEnabled': undeclared identifier
[13795->18/13830 ~17] CXX
obj/components/policy/policy/cloud_policy_generated.obj
FAILED: ninja -t msvc -e environment.x86 --
"d:\src\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC
@obj/components/policy/policy/cloud_policy_generated.obj.rsp /c
gen/policy/cloud_policy_generated.cc
/Foobj/components/policy/policy/cloud_policy_generated.obj
/Fd"obj/components/policy/policy_cc.pdb"
d:\src\cr3\src\out\debug\gen\policy\cloud_policy_generated.cc(5870): error
C2039: 'kTaskManagerEndProcessEnabled': is not a member of 'policy::key'
d:\src\cr3\src\out\debug\gen\policy\policy\policy_constants.h(37): note: see
declaration of 'policy::key'
d:\src\cr3\src\out\debug\gen\policy\cloud_policy_generated.cc(5870): error
C2065: 'kTaskManagerEndProcessEnabled': undeclared identifier
[13795->35/13830 ~0] CXX obj/v8/v8_base/objects.obj
ninja: build stopped: subcommand failed.

Maybe some dependencies aren't quite right for GN?

[scottmg, 2016-04-26 19:52:56]

On 2016/04/26 19:50:36, scottmg wrote:
> I'm getting build failure that seems related to this change on a relatively
> clean tree, using the GN Windows build.
> 
> [13795->2/13830 ~33] CXX obj/components/policy/policy/policy_constants.obj
> FAILED: ninja -t msvc -e environment.x86 --
>
"d:\src\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe"
> /nologo /showIncludes /FC
@obj/components/policy/policy/policy_constants.obj.rsp
> /c gen/policy/policy_constants.cc
> /Foobj/components/policy/policy/policy_constants.obj
> /Fd"obj/components/policy/policy_cc.pdb"
> d:\src\cr3\src\out\debug\gen\policy\policy_constants.cc(772): error C2039:
> 'kTaskManagerEndProcessEnabled': is not a member of 'policy::key'
> d:\src\cr3\src\out\debug\gen\policy\policy\policy_constants.h(37): note: see
> declaration of 'policy::key'
> d:\src\cr3\src\out\debug\gen\policy\policy_constants.cc(772): error C2065:
> 'kTaskManagerEndProcessEnabled': undeclared identifier
> [13795->18/13830 ~17] CXX
> obj/components/policy/policy/cloud_policy_generated.obj
> FAILED: ninja -t msvc -e environment.x86 --
>
"d:\src\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe"
> /nologo /showIncludes /FC
> @obj/components/policy/policy/cloud_policy_generated.obj.rsp /c
> gen/policy/cloud_policy_generated.cc
> /Foobj/components/policy/policy/cloud_policy_generated.obj
> /Fd"obj/components/policy/policy_cc.pdb"
> d:\src\cr3\src\out\debug\gen\policy\cloud_policy_generated.cc(5870): error
> C2039: 'kTaskManagerEndProcessEnabled': is not a member of 'policy::key'
> d:\src\cr3\src\out\debug\gen\policy\policy\policy_constants.h(37): note: see
> declaration of 'policy::key'
> d:\src\cr3\src\out\debug\gen\policy\cloud_policy_generated.cc(5870): error
> C2065: 'kTaskManagerEndProcessEnabled': undeclared identifier
> [13795->35/13830 ~0] CXX obj/v8/v8_base/objects.obj
> ninja: build stopped: subcommand failed.
> 
> Maybe some dependencies aren't quite right for GN?

Hmm, `rmdir /s/q out && regen && ninja -C out\Debug
obj/components/policy/policy/policy_constants.obj` made it work, but seems like
something's not quite right.

[Andrew T Wilson (Slow), 2016-04-27 08:32:28]

On 2016/04/26 19:52:56, scottmg wrote:
> On 2016/04/26 19:50:36, scottmg wrote:
> > I'm getting build failure that seems related to this change on a relatively
> > clean tree, using the GN Windows build.
> > 
> > [13795->2/13830 ~33] CXX obj/components/policy/policy/policy_constants.obj
> > FAILED: ninja -t msvc -e environment.x86 --
> >
>
"d:\src\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe"
> > /nologo /showIncludes /FC
> @obj/components/policy/policy/policy_constants.obj.rsp
> > /c gen/policy/policy_constants.cc
> > /Foobj/components/policy/policy/policy_constants.obj
> > /Fd"obj/components/policy/policy_cc.pdb"
> > d:\src\cr3\src\out\debug\gen\policy\policy_constants.cc(772): error C2039:
> > 'kTaskManagerEndProcessEnabled': is not a member of 'policy::key'
> > d:\src\cr3\src\out\debug\gen\policy\policy\policy_constants.h(37): note: see
> > declaration of 'policy::key'
> > d:\src\cr3\src\out\debug\gen\policy\policy_constants.cc(772): error C2065:
> > 'kTaskManagerEndProcessEnabled': undeclared identifier
> > [13795->18/13830 ~17] CXX
> > obj/components/policy/policy/cloud_policy_generated.obj
> > FAILED: ninja -t msvc -e environment.x86 --
> >
>
"d:\src\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe"
> > /nologo /showIncludes /FC
> > @obj/components/policy/policy/cloud_policy_generated.obj.rsp /c
> > gen/policy/cloud_policy_generated.cc
> > /Foobj/components/policy/policy/cloud_policy_generated.obj
> > /Fd"obj/components/policy/policy_cc.pdb"
> > d:\src\cr3\src\out\debug\gen\policy\cloud_policy_generated.cc(5870): error
> > C2039: 'kTaskManagerEndProcessEnabled': is not a member of 'policy::key'
> > d:\src\cr3\src\out\debug\gen\policy\policy\policy_constants.h(37): note: see
> > declaration of 'policy::key'
> > d:\src\cr3\src\out\debug\gen\policy\cloud_policy_generated.cc(5870): error
> > C2065: 'kTaskManagerEndProcessEnabled': undeclared identifier
> > [13795->35/13830 ~0] CXX obj/v8/v8_base/objects.obj
> > ninja: build stopped: subcommand failed.
> > 
> > Maybe some dependencies aren't quite right for GN?
> 
> Hmm, `rmdir /s/q out && regen && ninja -C out\Debug
> obj/components/policy/policy/policy_constants.obj` made it work, but seems
like
> something's not quite right.

Agreed. No new dependencies were added with this CL, so I suspect the existing
GN dependencies are just broken/incorrect. Who is the right person to look into
this?

[brettw, 2016-04-27 16:33:08]

I looked briefly and the build around the policy constants looks correct to me.

The error above implies that policy_constants.h isn't in sync with
policy_constants.cc. These are both generated by the same action
//components/policy:cloud_policy_code_generate so it doesn't seem obvious to me
how these could get out of sync.