appengine/findit/crash/test/crash_util_test.py - Issue 1861373003: [Findit] Initial code of findit for crash. Add scorers to apply heuristic rules.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/crash/test/crash_util_test.py

Issue 1861373003: [Findit] Initial code of findit for crash. Add scorers to apply heuristic rules. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Fix nits and doc strings. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« appengine/findit/crash/scorers/top_frame_index.py ('K') | « appengine/findit/crash/test/crash_test_suite.py ('k') | appengine/findit/crash/test/findit_for_crash_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from testing_utils import testing

	6

	7 from crash import crash_util

	8

	9

	10 class CrashUtilTest(testing.AppengineTestCase):

	11

	12 def testIsSameFilePath(self):

	13 path1 = 'third_party/a/b/c/file.cc'

	14 path2 = 'third_party/a/file.cc'

	15

	16 self.assertTrue(crash_util.IsSameFilePath(path1, path2))
	stgao 2016/04/15 18:35:19 Why these two are treated as the same file paths? Why these two are treated as the same file paths? Sharu 2016/04/15 22:59:47 This is the method we use in clusterfuzz all the t Show quoted text On 2016/04/15 18:35:19, stgao wrote: > Why these two are treated as the same file paths? This is the method we use in clusterfuzz all the time, I just port it over. So we assume if there are 3 parts mating, these 2 are the same. Can we rely on this assumption?
	17

	18 path1 = 'a/b/c/file.cc'

	19 path2 = 'a/b/c/file2.cc'

	20

	21 self.assertFalse(crash_util.IsSameFilePath(path1, path2))

	22

	23 path1 = 'a/b/c/d/e/file.cc'

	24 path2 = 'f/g/file.cc'

	25

	26 self.assertFalse(crash_util.IsSameFilePath(path1, path2))

OLD	NEW