Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: appengine/findit/crash/scorers/top_frame_index.py

Issue 1861373003: [Findit] Initial code of findit for crash. Add scorers to apply heuristic rules. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nits and doc strings. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 """TopFrameIndex scorer applies to all Result objects.
6
7 It represents a heuristic rule:
8 The less the top frame index (this result changed) is, the higher score.
9 """
10
11 from crash.scorers.scorer import Scorer
12
13 _MAX_TOP_N_FRAMES = 20
14 _INFINITY = 1000
15
16
17 class TopFrameIndex(Scorer):
18 def __init__(self, max_top_n=_MAX_TOP_N_FRAMES):
19 self.max_top_n = max_top_n
20
21 def GetMetric(self, result):
22 if not result.file_to_stack_infos:
23 return None
24
25 top_frame_index = _INFINITY
26 for _, stack_infos in result.file_to_stack_infos.iteritems():
27 for frame, _ in stack_infos:
28 top_frame_index = min(top_frame_index, frame.index)
29
30 return top_frame_index
31
32 def Score(self, top_frame_index):
33 if top_frame_index < self.max_top_n:
34 return 1 - top_frame_index / float(self.max_top_n)
stgao 2016/04/15 18:35:19 I think this is reasonable, but without experiment
Sharu 2016/04/15 22:59:47 Add a todo
35
36 return 0
37
38 def Reason(self, top_frame_index, score):
39 if score == 0:
40 return ''
41
42 return 'Top frame changed is frame #%d' % top_frame_index
stgao 2016/04/15 18:35:19 Doesn't "top frame" refer to the first frame?
Sharu 2016/04/15 22:59:47 Not necessarily true I guess, not sure, @mbarbella
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698