Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1861363002: Add hooks for changing priorities of warnings to errors in strong mode (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
Leaf, Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add hooks for changing priorities of warnings to errors in strong mode R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/f819f9fb079a2e674e9e0ff609383c7a2032d293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/protocol_server.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 2 chunks +9 lines, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Brian Wilkerson
This doesn't actually change anything, but does allow the severity of static warnings to be ...
4 years, 8 months ago (2016-04-06 15:29:07 UTC) #2
Leaf
lgtm
4 years, 8 months ago (2016-04-06 19:48:16 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as f819f9fb079a2e674e9e0ff609383c7a2032d293 (presubmit successful).
4 years, 8 months ago (2016-04-06 20:06:37 UTC) #5
Bob Nystrom
4 years, 8 months ago (2016-04-07 23:09:43 UTC) #7
Message was sent while issue was closed. 
In my change to upgrade all StaticTypeWarnings for strong mode, I inserted the
check in ErrorProcessor. That way I didn't have to do it in both analyzer_cli
and analysis_server (and presumably DDC). It's here:

https://github.com/dart-lang/sdk/blob/0c1e85ebadaa0680d4ff30acc1f3ac823c53756...

Maybe this should be done there too?

Powered by Google App Engine
This is Rietveld 408576698