Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1861353002: Split fxfa_objectacc.h into pieces. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Split fxfa_objectacc.h into pieces. This Cl splits apart the fxfa_objectacc.h file and moves the individual classes into the xfa/fxfa/parser directory. Committed: https://pdfium.googlesource.com/pdfium/+/44d054c6449edb63d9760ac6602b036ffec75a84

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2687 lines, -4476 lines) Patch
M BUILD.gn View 1 3 chunks +53 lines, -2 lines 0 comments Download
M xfa.gyp View 3 chunks +53 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_arc.h View 1 chunk +19 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_assist.h View 1 chunk +22 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_assist.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_bind.h View 1 chunk +22 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_bind.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_binditems.h View 1 chunk +25 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_binditems.cpp View 1 chunk +27 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_border.h View 1 chunk +19 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_box.h View 1 chunk +50 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_box.cpp View 1 chunk +168 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_calculate.h View 1 chunk +25 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_calculate.cpp View 1 chunk +32 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_caption.h View 1 chunk +29 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_caption.cpp View 1 chunk +41 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_corner.h View 1 chunk +19 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_data.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_data.cpp View 1 chunk +80 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_edge.h View 1 chunk +19 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_event.h View 1 chunk +33 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_event.cpp View 1 chunk +49 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_exdata.h View 1 chunk +22 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_exdata.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_fill.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_fill.cpp View 1 chunk +103 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_font.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_font.cpp View 1 1 chunk +92 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_image.h View 1 chunk +33 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_image.cpp View 1 chunk +54 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_line.h View 1 chunk +25 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_line.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_margin.h View 1 chunk +25 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_margin.cpp View 1 chunk +32 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_occur.h View 1 chunk +26 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_occur.cpp View 1 chunk +67 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_para.h View 1 chunk +29 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_para.cpp View 1 chunk +59 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_rectangle.h View 1 chunk +19 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_script.h View 1 chunk +32 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_script.cpp View 1 chunk +31 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_stroke.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_stroke.cpp View 1 chunk +105 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_submit.h View 1 chunk +26 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_submit.cpp View 1 chunk +27 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_text.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_text.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
A xfa/fxfa/parser/cxfa_tooltip.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_tooltip.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
A xfa/fxfa/parser/cxfa_validate.h View 1 chunk +44 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_validate.cpp View 1 chunk +119 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_value.h View 1 chunk +35 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_value.cpp View 1 chunk +56 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_widgetdata.h View 1 chunk +181 lines, -0 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_widgetdata.cpp View 60 chunks +364 lines, -1226 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 2 chunks +3 lines, -1 line 0 comments Download
D xfa/fxfa/parser/xfa_objectacc_imp.cpp View 1 chunk +0 lines, -2659 lines 0 comments Download
M xfa/fxfa/parser/xfa_script.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_utils.h View 2 chunks +7 lines, -3 lines 0 comments Download
D xfa/include/fxfa/fxfa_objectacc.h View 1 1 chunk +0 lines, -561 lines 0 comments Download
M xfa/include/fxfa/fxfa_widget.h View 1 1 chunk +9 lines, -1 line 0 comments Download
M xfa/include/fxfa/xfa_ffwidget.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL. https://codereview.chromium.org/1861353002/diff/1/xfa/fxfa/parser/cxfa_data.h File xfa/fxfa/parser/cxfa_data.h (right): https://codereview.chromium.org/1861353002/diff/1/xfa/fxfa/parser/cxfa_data.h#newcode18 xfa/fxfa/parser/cxfa_data.h:18: static FX_ARGB ToColor(const CFX_WideStringC& wsValue); This seemed like ...
4 years, 8 months ago (2016-04-06 14:56:03 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1861353002/diff/1/xfa/fxfa/parser/xfa_object.h File xfa/fxfa/parser/xfa_object.h (right): https://codereview.chromium.org/1861353002/diff/1/xfa/fxfa/parser/xfa_object.h#newcode90 xfa/fxfa/parser/xfa_object.h:90: typedef CFX_ArrayTemplate<CXFA_Object*> CXFA_ObjArray; nit: using CFXA_ObjArray = FX_ArrayTemplate<CXFA_Object*>;
4 years, 8 months ago (2016-04-06 17:03:53 UTC) #3
dsinclair
https://codereview.chromium.org/1861353002/diff/1/xfa/fxfa/parser/xfa_object.h File xfa/fxfa/parser/xfa_object.h (right): https://codereview.chromium.org/1861353002/diff/1/xfa/fxfa/parser/xfa_object.h#newcode90 xfa/fxfa/parser/xfa_object.h:90: typedef CFX_ArrayTemplate<CXFA_Object*> CXFA_ObjArray; On 2016/04/06 17:03:53, Tom Sepez wrote: ...
4 years, 8 months ago (2016-04-06 17:10:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861353002/20001
4 years, 8 months ago (2016-04-06 17:10:47 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 17:23:50 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/44d054c6449edb63d9760ac6602b036ffec7...

Powered by Google App Engine
This is Rietveld 408576698