Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1861343002: Remove "reportWheelOverscroll" from Blink settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit tests and moved check to RenderWidget Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebSettingsImpl.cpp ('k') | third_party/WebKit/public/web/WebSettings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 16b9f9e700d3309cc0f9efc9823376ccc4103f64..a372a41352ddd192c45767157e2fd05b6022f0a5 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -8339,14 +8339,6 @@ TEST_P(WebFrameOverscrollTest, ReportingLatestOverscrollForElasticOverscroll)
webViewHelper.initializeAndLoad(m_baseURL + "overscroll/overscroll.html", true, 0, &client, configureAndroid);
webViewHelper.resize(WebSize(200, 200));
- // On disabling ReportWheelOverscroll, overscroll is not reported on MouseWheel.
- webViewHelper.webView()->settings()->setReportWheelOverscroll(false);
- EXPECT_CALL(client, didOverscroll(_, _, _, _)).Times(0);
- ScrollByWheel(&webViewHelper, 10, 10, 1000, 1000);
- Mock::VerifyAndClearExpectations(&client);
-
- // On enabling ReportWheelOverscroll, overscroll is reported on MouseWheel.
- webViewHelper.webView()->settings()->setReportWheelOverscroll(true);
EXPECT_CALL(client, didOverscroll(WebFloatSize(-1000, -1000), WebFloatSize(-1000, -1000), WebFloatPoint(), WebFloatSize()));
ScrollByWheel(&webViewHelper, 10, 10, 1000, 1000);
Mock::VerifyAndClearExpectations(&client);
« no previous file with comments | « third_party/WebKit/Source/web/WebSettingsImpl.cpp ('k') | third_party/WebKit/public/web/WebSettings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698