Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1861343002: Remove "reportWheelOverscroll" from Blink settings. (Closed)

Created:
4 years, 8 months ago by bokan
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, dtapuska+blinkwatch_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "reportWheelOverscroll" from Blink settings. This flag complicates Blink event handling needlessly. It's only needed on Mac where we use it to disable the elastic rubber banding effect on overscroll. This patch removes the setting and always reports overscroll for wheel from Blink. In the renderer content layer, we check if the ElasticOverscroll system setting is enabled on Mac and block the overscroll if not (there's no touch overscroll to worry about on Mac). Otherwise just allow the overscroll deltas to be sent to the browser since they have no effect on other platforms. BUG=505516 Committed: https://crrev.com/731ec38829ae017204d43337da90ea7ca2f15e51 Cr-Commit-Position: refs/heads/master@{#385642}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fixed unit tests and moved check to RenderWidget #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -25 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M content/test/fake_compositor_dependencies.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861343002/1
4 years, 8 months ago (2016-04-06 14:13:36 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/183688)
4 years, 8 months ago (2016-04-06 14:27:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861343002/40001
4 years, 8 months ago (2016-04-06 14:30:37 UTC) #7
bokan
4 years, 8 months ago (2016-04-06 15:21:28 UTC) #10
dtapuska
On 2016/04/06 15:21:28, bokan wrote: lgtm
4 years, 8 months ago (2016-04-06 15:29:20 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/206487)
4 years, 8 months ago (2016-04-06 16:02:45 UTC) #13
bokan
+rbyers@ for WebKit/public +avi@ for content/
4 years, 8 months ago (2016-04-06 23:48:31 UTC) #15
Rick Byers
public LGTM
4 years, 8 months ago (2016-04-06 23:50:03 UTC) #16
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-07 01:51:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861343002/60001
4 years, 8 months ago (2016-04-07 01:52:51 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 8 months ago (2016-04-07 03:16:57 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 03:20:05 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/731ec38829ae017204d43337da90ea7ca2f15e51
Cr-Commit-Position: refs/heads/master@{#385642}

Powered by Google App Engine
This is Rietveld 408576698