Adds extension name to the screencast notification bar.

Adds extension name to the screencast notification bar.
Also adds the web content origin to the window picker text.
No change to both text if the extension itself is requesting the stream, instead of sharing it with a tab. Screen sharing without window picker (i.e. chromeMediaSource:screen) is not affected.

BUG=341729
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255581

[jiayl, 2014-03-05 17:57:34]

ben: please review chrome/ui/views
rsesek: please review chrome/ui/cocoa
sergeyu: please review all

[Robert Sesek, 2014-03-05 18:11:49]

https://codereview.chromium.org/186133005/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/186133005/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:9616: +      <message
name="IDS_MEDIA_SCREEN_CAPTURE_NOTIFICATION_TEXT_2" desc="label used in screen
capture notification UI to show the screen sharing status when the stream is
registered by an extension and used by web contents">
I don't understand the _2 in the naming of these resources.

[jiayl, 2014-03-05 18:19:21]

https://codereview.chromium.org/186133005/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/186133005/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:9616: +      <message
name="IDS_MEDIA_SCREEN_CAPTURE_NOTIFICATION_TEXT_2" desc="label used in screen
capture notification UI to show the screen sharing status when the stream is
registered by an extension and used by web contents">
On 2014/03/05 18:11:49, rsesek wrote:
> I don't understand the _2 in the naming of these resources.

_2 is used when the consumer of the screencast stream is different from the
extension that shows the window picker. I didn't think of a concise name to
reflect the difference. What do you suggest?

[Robert Sesek, 2014-03-05 18:38:31]

https://codereview.chromium.org/186133005/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/186133005/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:9616: +      <message
name="IDS_MEDIA_SCREEN_CAPTURE_NOTIFICATION_TEXT_2" desc="label used in screen
capture notification UI to show the screen sharing status when the stream is
registered by an extension and used by web contents">
On 2014/03/05 18:19:21, jiayl wrote:
> On 2014/03/05 18:11:49, rsesek wrote:
> > I don't understand the _2 in the naming of these resources.
> 
> _2 is used when the consumer of the screencast stream is different from the
> extension that shows the window picker. I didn't think of a concise name to
> reflect the difference. What do you suggest?

That does seem like a difference that's hard to convey concisely. I don't have
any suggestions, except maybe make the desc="" call out this difference more
clearly?

[jiayl, 2014-03-05 19:05:55]

On 2014/03/05 18:38:31, rsesek wrote:
>
https://codereview.chromium.org/186133005/diff/40001/chrome/app/generated_res...
> File chrome/app/generated_resources.grd (right):
> 
>
https://codereview.chromium.org/186133005/diff/40001/chrome/app/generated_res...
> chrome/app/generated_resources.grd:9616: +      <message
> name="IDS_MEDIA_SCREEN_CAPTURE_NOTIFICATION_TEXT_2" desc="label used in screen
> capture notification UI to show the screen sharing status when the stream is
> registered by an extension and used by web contents">
> On 2014/03/05 18:19:21, jiayl wrote:
> > On 2014/03/05 18:11:49, rsesek wrote:
> > > I don't understand the _2 in the naming of these resources.
> > 
> > _2 is used when the consumer of the screencast stream is different from the
> > extension that shows the window picker. I didn't think of a concise name to
> > reflect the difference. What do you suggest?
> 
> That does seem like a difference that's hard to convey concisely. I don't have
> any suggestions, except maybe make the desc="" call out this difference more
> clearly?

Done

[Robert Sesek, 2014-03-05 19:08:27]

cocoa/ LGTM

https://codereview.chromium.org/186133005/diff/160001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h
(right):

https://codereview.chromium.org/186133005/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h:55: //
|appName| will be used to format the dialog's title and the label.
Document |targetName|

[jiayl, 2014-03-05 19:12:12]

https://codereview.chromium.org/186133005/diff/160001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h
(right):

https://codereview.chromium.org/186133005/diff/160001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h:55: //
|appName| will be used to format the dialog's title and the label.
On 2014/03/05 19:08:27, rsesek wrote:
> Document |targetName|

Done.

[Ben Goodger (Google), 2014-03-06 03:10:31]

ui/views lgtm

[Sergey Ulanov, 2014-03-06 19:20:05]

lgtm

https://codereview.chromium.org/186133005/diff/180001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/186133005/diff/180001/chrome/app/generated_re...
chrome/app/generated_resources.grd:9616: +      <message
name="IDS_MEDIA_SCREEN_CAPTURE_NOTIFICATION_TEXT_2" desc="label used in screen
capture notification UI to show the screen sharing status when the stream is
consumed by a tab instead of the app initiating the window picker">
suggest using _DELEGATED suffix instead of _2

https://codereview.chromium.org/186133005/diff/180001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm
(right):

https://codereview.chromium.org/186133005/diff/180001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm:61:
targetName:base::ASCIIToUTF16("Screenshare Test")]);
nit: Maybe "http://example.com" as this supposed to be an origin.

[jiayl, 2014-03-06 22:01:30]

https://codereview.chromium.org/186133005/diff/180001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/186133005/diff/180001/chrome/app/generated_re...
chrome/app/generated_resources.grd:9616: +      <message
name="IDS_MEDIA_SCREEN_CAPTURE_NOTIFICATION_TEXT_2" desc="label used in screen
capture notification UI to show the screen sharing status when the stream is
consumed by a tab instead of the app initiating the window picker">
On 2014/03/06 19:20:05, Sergey Ulanov wrote:
> suggest using _DELEGATED suffix instead of _2

Done.

https://codereview.chromium.org/186133005/diff/180001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm
(right):

https://codereview.chromium.org/186133005/diff/180001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm:61:
targetName:base::ASCIIToUTF16("Screenshare Test")]);
On 2014/03/06 19:20:05, Sergey Ulanov wrote:
> nit: Maybe "http://example.com" as this supposed to be an origin.

Done.

[jiayl, 2014-03-06 22:01:35]

The CQ bit was checked by jiayl@chromium.org

[commit-bot: I haz the power, 2014-03-06 22:33:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jiayl@chromium.org/186133005/220001

[commit-bot: I haz the power, 2014-03-07 11:27:53]

Change committed as 255581