Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 186133003: Suppresses OneClickSigninHelper on webUI (Closed)

Created:
6 years, 9 months ago by guohui
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : added logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
guohui
Hey Roger, could you please take a look at the CL? Thanks, Hui
6 years, 9 months ago (2014-03-03 22:21:20 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 9 months ago (2014-03-03 22:32:39 UTC) #2
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 9 months ago (2014-03-03 22:32:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/186133003/20001
6 years, 9 months ago (2014-03-03 22:36:24 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 23:32:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=273439
6 years, 9 months ago (2014-03-03 23:32:59 UTC) #6
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 9 months ago (2014-03-03 23:38:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/186133003/20001
6 years, 9 months ago (2014-03-03 23:39:45 UTC) #8
guohui
6 years, 9 months ago (2014-03-03 23:49:18 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 manually as r254606 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698