Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1861323003: Have the mock PlatformSpeechSynthesizer ignore pause/resume sometimes. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
haraken, dmazzoni
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have the mock PlatformSpeechSynthesizer ignore pause/resume sometimes. Should pause()/resume() be attempted without nothing being currently spoken, just ignore. R= BUG=600664 Committed: https://crrev.com/0f7b9d798c423f45a11d8afa10807c5a0bc1c646 Cr-Commit-Position: refs/heads/master@{#385670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-mock-no-crash.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-mock-no-crash-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look. fuzzer noise.
4 years, 8 months ago (2016-04-06 21:21:01 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-06 23:46:15 UTC) #3
dmazzoni
lgtm too
4 years, 8 months ago (2016-04-07 05:06:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861323003/1
4 years, 8 months ago (2016-04-07 05:26:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 05:32:18 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 05:33:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f7b9d798c423f45a11d8afa10807c5a0bc1c646
Cr-Commit-Position: refs/heads/master@{#385670}

Powered by Google App Engine
This is Rietveld 408576698