Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1861323002: Fix annotated disassembly in ll_prof.py (Closed)

Created:
4 years, 8 months ago by Stefano Sanfilippo
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix annotated disassembly in ll_prof.py An overzealous removal in https://crrev.com/9e39a9fff1c2966a3f650a4c31dbbe533886d614 caused the disassembly not to be annotated with ticks, even when requested. LOG=N Committed: https://crrev.com/cf8de862abde2e92d8441ad66d6bc8f7d8dc3638 Cr-Commit-Position: refs/heads/master@{#35298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/ll_prof.py View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Benedikt Meurer
LGTM, thanks.
4 years, 8 months ago (2016-04-06 11:33:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861323002/1
4 years, 8 months ago (2016-04-06 11:34:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861323002/1
4 years, 8 months ago (2016-04-06 11:37:29 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 12:01:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861323002/1
4 years, 8 months ago (2016-04-06 12:32:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 12:38:27 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 12:38:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf8de862abde2e92d8441ad66d6bc8f7d8dc3638
Cr-Commit-Position: refs/heads/master@{#35298}

Powered by Google App Engine
This is Rietveld 408576698