LayouTests: Run virtual http/tests as http tests

LayouTests: Run virtual http/tests as http tests

It looks currently only virtual/stable/http tests can run as http tests
(with http server) in virtual LayoutTest settings?

TEST=n/a
BUG=

Committed: https://crrev.com/c8e33bbf1f5da85536209b384f363dd13305eea1
Cr-Commit-Position: refs/heads/master@{#385632}

[kinuko, 2016-04-06 10:31:30]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 10:31:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861313002/1

[kinuko, 2016-04-06 10:31:45]

Description was changed from

==========
LayouTests: Run virtual http/tests as http tests

It looks currently only virtual/stable/http tests can run as http tests
(with http server) in virtual LayoutTest settings?

TEST=n/a
BUG=
==========

to

==========
LayouTests: Run virtual http/tests as http tests

It looks currently only virtual/stable/http tests can run as http tests
(with http server) in virtual LayoutTest settings?

TEST=n/a
BUG=
==========

[kinuko, 2016-04-06 10:31:45]

kinuko@chromium.org changed reviewers:
+ dpranke@chromium.org

[kinuko, 2016-04-06 10:34:15]

Hi Dirk, does a change like this make sense? I had tough time when I tried to
add virtual http tests (something like this:
https://codereview.chromium.org/1859383002/) and adding this change seems to
have made it work.

[commit-bot: I haz the power, 2016-04-06 12:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 12:15:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kinuko, 2016-04-06 14:01:32]

Hmm, webkit_tests's failing... so something isn't working well :(

[kinuko, 2016-04-06 14:24:40]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 14:25:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861313002/20001

[commit-bot: I haz the power, 2016-04-06 15:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 15:32:56]

Dry run: This issue passed the CQ dry run.

[kinuko, 2016-04-06 15:42:13]

Ok, now it passes all tests. PTL

[Dirk Pranke, 2016-04-06 21:54:25]

lgtm w/ suggested change (which is totally different than what you did ;).

https://codereview.chromium.org/1861313002/diff/20001/third_party/WebKit/Tool...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
(right):

https://codereview.chromium.org/1861313002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:229:
bool(re.match(self.VIRTUAL_HTTP_SUBDIR_PATTERN, test))
I think we can make this a little easier and just have this be:

  def _is_http_test(self, test):
    return (port.TEST_PATH_SEPARATOR + 'http' + port.TEST_PATH_SEPARATOR) in
test

it doesn't look like there are any directories with '/http/' in the name that
aren't actually for http.

All of the websocket tests are in /http/ as well so we don't need that clause.

[kinuko, 2016-04-06 23:47:08]

On 2016/04/06 21:54:25, Dirk Pranke wrote:
> lgtm w/ suggested change (which is totally different than what you did ;).

Ok sure, will simplify it like that before landing =)

[kinuko, 2016-04-07 00:21:11]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2016-04-07 00:21:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1861313002/#ps40001
(title: "simplify")

[commit-bot: I haz the power, 2016-04-07 00:22:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861313002/40001

[commit-bot: I haz the power, 2016-04-07 01:25:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 01:25:42]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kinuko, 2016-04-07 01:40:10]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[kinuko, 2016-04-07 01:40:16]

The CQ bit was unchecked by kinuko@chromium.org

[kinuko, 2016-04-07 01:40:20]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2016-04-07 01:40:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1861313002/#ps60001
(title: "restore other conditions")

[commit-bot: I haz the power, 2016-04-07 01:40:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861313002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861313002/60001

[kinuko, 2016-04-07 02:03:20]

It turns out that I still seem to need test.startswith('http/') (leading slash
misses this) and is_websocket_tests too, so I restored two original lines and
just replaced 

self.VIRTUAL_HTTP_SUBDIR in test

with

self._port.TEST_PATH_SEPARATOR + self.HTTP_SUBDIR in test

I'm landing this (if all tests pass), if you want a follow-up cleanup please let
me know!  Thanks

[commit-bot: I haz the power, 2016-04-07 02:43:28]

Description was changed from

==========
LayouTests: Run virtual http/tests as http tests

It looks currently only virtual/stable/http tests can run as http tests
(with http server) in virtual LayoutTest settings?

TEST=n/a
BUG=
==========

to

==========
LayouTests: Run virtual http/tests as http tests

It looks currently only virtual/stable/http tests can run as http tests
(with http server) in virtual LayoutTest settings?

TEST=n/a
BUG=
==========

[commit-bot: I haz the power, 2016-04-07 02:43:29]

Committed patchset #4 (id:60001)

[Dirk Pranke, 2016-04-07 02:44:53]

On 2016/04/07 02:03:20, kinuko wrote:
> It turns out that I still seem to need test.startswith('http/') (leading slash
> misses this) and is_websocket_tests too, so I restored two original lines and
> just replaced 
> 
> self.VIRTUAL_HTTP_SUBDIR in test
> 
> with
> 
> self._port.TEST_PATH_SEPARATOR + self.HTTP_SUBDIR in test
> 
> I'm landing this (if all tests pass), if you want a follow-up cleanup please
let
> me know!  Thanks

Looks like some webkitpy tests failed; maybe they just need to be updated.

Anyway, patchset #4 lgtm, too .

[commit-bot: I haz the power, 2016-04-07 02:45:13]

Description was changed from

==========
LayouTests: Run virtual http/tests as http tests

It looks currently only virtual/stable/http tests can run as http tests
(with http server) in virtual LayoutTest settings?

TEST=n/a
BUG=
==========

to

==========
LayouTests: Run virtual http/tests as http tests

It looks currently only virtual/stable/http tests can run as http tests
(with http server) in virtual LayoutTest settings?

TEST=n/a
BUG=

Committed: https://crrev.com/c8e33bbf1f5da85536209b384f363dd13305eea1
Cr-Commit-Position: refs/heads/master@{#385632}
==========

[commit-bot: I haz the power, 2016-04-07 02:45:14]

Patchset 4 (id:??) landed as
https://crrev.com/c8e33bbf1f5da85536209b384f363dd13305eea1
Cr-Commit-Position: refs/heads/master@{#385632}