Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(249)

Issue 1861243002: Check the mime type of cross-origin CSS fetched via the Service Worker. (Closed)

Created:
3 years, 3 months ago by horo
Modified:
3 years, 3 months ago
Reviewers:
Mike West
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, rwlbuis, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check the mime type of cross-origin CSS fetched via the Service Worker. BUG=598077 Committed: https://crrev.com/3d9fa8719b092361eb0a6baec91d378599e74b75 Cr-Commit-Position: refs/heads/master@{#385441}

Patch Set 1 #

Total comments: 6

Patch Set 2 : incorporated mkws's comment #

Patch Set 3 : add files #

Messages

Total messages: 16 (7 generated)
horo
Could you please review this?
3 years, 3 months ago (2016-04-06 06:20:12 UTC) #2
Mike West
One question about synthetic responses. The rest LGTM, thanks! https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html File third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html (right): https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html#newcode17 third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html:17: ...
3 years, 3 months ago (2016-04-06 06:54:17 UTC) #3
horo
Thank you. https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html File third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html (right): https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html#newcode17 third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html:17: }) On 2016/04/06 06:54:16, Mike West wrote: ...
3 years, 3 months ago (2016-04-06 08:13:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861243002/20001
3 years, 3 months ago (2016-04-06 08:35:34 UTC) #7
Mike West
Still LGTM, thank you!
3 years, 3 months ago (2016-04-06 08:48:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/207769)
3 years, 3 months ago (2016-04-06 09:20:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861243002/40001
3 years, 3 months ago (2016-04-06 10:54:30 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 3 months ago (2016-04-06 12:06:16 UTC) #14
commit-bot: I haz the power
3 years, 3 months ago (2016-04-06 12:07:50 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3d9fa8719b092361eb0a6baec91d378599e74b75
Cr-Commit-Position: refs/heads/master@{#385441}

Powered by Google App Engine
This is Rietveld 408576698