Check the mime type of cross-origin CSS fetched via the Service Worker.

Check the mime type of cross-origin CSS fetched via the Service Worker.

BUG=598077
Committed: https://crrev.com/3d9fa8719b092361eb0a6baec91d378599e74b75
Cr-Commit-Position: refs/heads/master@{#385441}

[horo, 2016-04-06 06:20:11]

horo@chromium.org changed reviewers:
+ mkwst@chromium.org

[horo, 2016-04-06 06:20:12]

Could you please review this?

[Mike West, 2016-04-06 06:54:17]

One question about synthetic responses. The rest LGTM, thanks!

https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html
(right):

https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html:17:
})
Nit: These are prettier as arrow functions (e.g. `.then(r => wait_for_state(t,
r.installing, 'activated')`), but that's personal preference.

https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/StyleSheetContents.cpp (right):

https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/StyleSheetContents.cpp:327: // FIXME: When we
will use the original URL as the base URL, we can remove this check.
crbug.com/553535
Nit: s/FIXME/TODO(horo)/

https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/StyleSheetContents.cpp:328: if
(cachedStyleSheet->response().wasFetchedViaServiceWorker() &&
!securityOrigin->canRequest(cachedStyleSheet->response().originalURLViaServiceWorker()))
What do we do for purely synthetic responses? It seems like those ought to be
considered same-origin.

[horo, 2016-04-06 08:13:50]

Thank you.

https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html
(right):

https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-cross-origin-mime-check.html:17:
})
On 2016/04/06 06:54:16, Mike West wrote:
> Nit: These are prettier as arrow functions (e.g. `.then(r => wait_for_state(t,
> r.installing, 'activated')`), but that's personal preference.

Done.

https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/StyleSheetContents.cpp (right):

https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/StyleSheetContents.cpp:327: // FIXME: When we
will use the original URL as the base URL, we can remove this check.
crbug.com/553535
On 2016/04/06 06:54:16, Mike West (OOO through 31st) wrote:
> Nit: s/FIXME/TODO(horo)/

Done.

https://codereview.chromium.org/1861243002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/StyleSheetContents.cpp:328: if
(cachedStyleSheet->response().wasFetchedViaServiceWorker() &&
!securityOrigin->canRequest(cachedStyleSheet->response().originalURLViaServiceWorker()))
On 2016/04/06 06:54:16, Mike West wrote:
> What do we do for purely synthetic responses? It seems like those ought to be
> considered same-origin.

Done.
Added isEmpty() checking.

[horo, 2016-04-06 08:35:13]

The CQ bit was checked by horo@chromium.org

[horo, 2016-04-06 08:35:14]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1861243002/#ps20001
(title: "incorporated mkws's comment")

[commit-bot: I haz the power, 2016-04-06 08:35:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861243002/20001

[Mike West, 2016-04-06 08:48:21]

Still LGTM, thank you!

[commit-bot: I haz the power, 2016-04-06 09:20:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 09:20:30]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-04-06 10:54:24]

The CQ bit was checked by horo@chromium.org

[horo, 2016-04-06 10:54:25]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1861243002/#ps40001
(title: "add files")

[commit-bot: I haz the power, 2016-04-06 10:54:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861243002/40001

[commit-bot: I haz the power, 2016-04-06 12:06:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-06 12:07:49]

Description was changed from

==========
Check the mime type of cross-origin CSS fetched via the Service Worker.

BUG=598077
==========

to

==========
Check the mime type of cross-origin CSS fetched via the Service Worker.

BUG=598077

Committed: https://crrev.com/3d9fa8719b092361eb0a6baec91d378599e74b75
Cr-Commit-Position: refs/heads/master@{#385441}
==========

[commit-bot: I haz the power, 2016-04-06 12:07:50]

Patchset 3 (id:??) landed as
https://crrev.com/3d9fa8719b092361eb0a6baec91d378599e74b75
Cr-Commit-Position: refs/heads/master@{#385441}