Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/browser/ui/apps/app_info_dialog.h

Issue 1861233003: Prepare for building with enable_app_list=0 on Desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to master (dependent CL landed) Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/apps/app_info_dialog.h
diff --git a/chrome/browser/ui/apps/app_info_dialog.h b/chrome/browser/ui/apps/app_info_dialog.h
index 62a25bb498c9db1b9e59e83edf35ccf67653e693..50b221824f0ada5b0c2f3f47e2e0cbdb273a0ce2 100644
--- a/chrome/browser/ui/apps/app_info_dialog.h
+++ b/chrome/browser/ui/apps/app_info_dialog.h
@@ -25,7 +25,9 @@ class Size;
// Used for UMA to track where the App Info dialog is launched from.
Devlin 2016/05/05 16:01:36 DANGER! These enums are used for UMA. #if defing
tapted 2016/05/06 02:36:56 Eep - thanks for catching this. Removed the #ifdef
enum AppInfoLaunchSource {
- FROM_APP_LIST, // Launched from the app list context menu.
+#if defined(ENABLE_APP_LIST)
+ FROM_APP_LIST, // Launched from the app list context menu.
+#endif
FROM_EXTENSIONS_PAGE, // Launched from the chrome://extensions page.
FROM_APPS_PAGE, // Launched from chrome://apps context menu.
NUM_LAUNCH_SOURCES,
@@ -38,6 +40,7 @@ bool CanShowAppInfoDialog();
// Returns the size of the native window container for the app info dialog.
gfx::Size GetAppInfoNativeDialogSize();
+#if defined(ENABLE_APP_LIST)
// Shows the chrome app information as a frameless window for the given |app|
// and |profile| at the given |app_list_bounds|. Appears 'inside' the app list.
void ShowAppInfoInAppList(gfx::NativeWindow parent,
@@ -45,6 +48,7 @@ void ShowAppInfoInAppList(gfx::NativeWindow parent,
Profile* profile,
const extensions::Extension* app,
const base::Closure& close_callback);
+#endif
// Shows the chrome app information in a native dialog box of the given |size|.
void ShowAppInfoInNativeDialog(content::WebContents* web_contents,

Powered by Google App Engine
This is Rietveld 408576698