build/common.gypi - Issue 1861233003: Prepare for building with enable_app_list=0 on Desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1861233003: Prepare for building with enable_app_list=0 on Desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: drop patchset dependency, rebase to master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 3ca0957941fb1ce7db7ae24d2aa79e1d6a16b8c9..f60184be225db8229f41fff97ba2bc53b04725cd 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -259,7 +259,7 @@

}],

# Enable App Launcher everywhere but mobile.

- ['OS!="ios" and OS!="android"', {

+ ['OS!="ios" and OS!="android" and chromecast==0', {

Matt Giuca 2016/05/03 07:31:15 Delightful! Can we just change this to a positive

tapted 2016/05/04 09:55:43 That becomes tricky since chromecast \implies{} OS

Matt Giuca 2016/05/05 00:26:30 Acknowledged.

'enable_app_list%': 1,

}, {

'enable_app_list%': 0,

« no previous file with comments | « build/all.gyp ('k') | build/config/features.gni » ('j') | build/config/features.gni » ('J')