Issue 186123006: zero copy - NOT FOR REVIEW

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 186123006: zero copy - NOT FOR REVIEW

Created:
6 years, 9 months ago by fjhenigman

Modified:
6 years, 9 months ago

Reviewers:
reveman

CC:
reveman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

zero copy - NOT FOR REVIEW intel only, requires - mesa patch (https://chromium-review.googlesource.com/188719) - not-too-old kernel (chromeos kernel-next, i.e 3.8.11 works) - --no-sandbox --ui-enable-map-image --ui-enable-impl-side-painting environment variable ZCOPY=untiled|tiled to enable, unset to disable --trace-to-console=zcopy for debugging output

Patch Set 1 #

Patch Set 2 : re-upload #

Total comments: 1

Patch Set 3 : minus ui-map-image and ui-impl-side setting, plus tiled mode #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+395 lines, -13 lines)			Patch
M	content/browser/gpu/browser_gpu_channel_host_factory.cc	View	1 2	2 chunks	+163 lines, -0 lines	0 comments	Download
M	content/common/child_process_messages.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/gpu/client/gpu_channel_host.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
A	content/common/gpu/client/gpu_memory_buffer_impl_foobar.h	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	content/common/gpu/client/gpu_memory_buffer_impl_foobar.cc	View	1 2	1 chunk	+100 lines, -0 lines	0 comments	Download
M	content/content_browser.gypi	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/content_common.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/gfx/gpu_memory_buffer.h	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	ui/gl/gl.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	ui/gl/gl_image_foobar.h	View		2 chunks	+9 lines, -11 lines	0 comments	Download
A	ui/gl/gl_image_foobar.cc	View	1 2	1 chunk	+60 lines, -0 lines	0 comments	Download
M	ui/gl/gl_image_x11.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

reveman

6 years, 9 months ago (2014-03-07 19:35:12 UTC) #1

https://codereview.chromium.org/186123006/diff/20001/ui/compositor/layer.h
File ui/compositor/layer.h (right):

https://codereview.chromium.org/186123006/diff/20001/ui/compositor/layer.h#ne...
ui/compositor/layer.h:461: scoped_refptr<cc::Layer> content_layer_;
Let's move this and layer.cc changes into a separate patch that adds a
--ui-enable-impl-side-painting flag and land that first.

I think the code should be consistent with how we handle this in:
src/webkit/renderer/compositor_bindings/web_content_layer_impl.cc

Expand Messages | Collapse Messages