Issue 186123003: Fix HConstants with Smi-ranged HeapNumber values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 186123003: Fix HConstants with Smi-ranged HeapNumber values (Closed)

Created:
6 years, 9 months ago by Jakob Kummerow

Modified:
6 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 9 months ago

		Unified diffs	Side-by-side diffs	Stats (+28 lines, -13 lines)
	M	src/hydrogen-instructions.cc	View	2 chunks	+10 lines, -2 lines	0 comments
	A +	test/mjsunit/regress/regress-crbug-349878.js	View	1 chunk	+18 lines, -11 lines	0 comments

Total messages: 3 (0 generated)

Jakob Kummerow

PTAL. And thanks for doing most of the legwork on this one!

6 years, 9 months ago (2014-03-06 16:12:14 UTC) #1

Yang

On 2014/03/06 16:12:14, Jakob wrote: > PTAL. > > And thanks for doing most of ...

6 years, 9 months ago (2014-03-06 16:17:27 UTC) #2

Jakob Kummerow

6 years, 9 months ago (2014-03-06 16:21:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19693 (tree was closed).