Make recipes.py run give better messages.

Make recipes.py run give better messages.

BUG=

Committed: https://github.com/luci/recipes-py/commit/85dbcfb4d81379d40b4461436daa5264008904bf

[martiniss, 2016-04-06 00:27:42]

martiniss@chromium.org changed reviewers:
+ iannucci@chromium.org

[martiniss, 2016-04-06 00:27:43]

PTAL

https://codereview.chromium.org/1861203002/diff/40001/recipe_engine/package.py
File recipe_engine/package.py (left):

https://codereview.chromium.org/1861203002/diff/40001/recipe_engine/package.p...
recipe_engine/package.py:388: def loop_over_recipe_modules():
Derp.

https://codereview.chromium.org/1861203002/diff/40001/recipe_engine/run.py
File recipe_engine/run.py (right):

https://codereview.chromium.org/1861203002/diff/40001/recipe_engine/run.py#ne...
recipe_engine/run.py:1: # Copyright (c) 2016 The Chromium Authors. All rights
reserved.
The license checker was complaining ¯\_(ツ)_/¯

[iannucci, 2016-04-14 01:18:29]

lgtm, though make sure to test the suggested invocation from the root of build,
or some other wacky place.  Could we use the relative directory of the current
repo and print a CD command at the top? E.g.

  cd $(git rev-parse --show-toplevel)/$(git rev-parse --show-prefix)
  python ./recipes.py .....

?

https://chromiumcodereview.appspot.com/1861203002/diff/60001/recipe_engine/ru...
File recipe_engine/run.py (right):

https://chromiumcodereview.appspot.com/1861203002/diff/60001/recipe_engine/ru...
recipe_engine/run.py:228: '.', root_package.relative_recipes_dir, 'recipes.py'),
recipe),
I think there's a discrepancy between run_recipe and recipes.py; particularly,
run_recipe sets the CWD. Unless you fixed this some other way?

[iannucci, 2016-04-14 01:21:34]

On 2016/04/14 at 01:18:29, iannucci wrote:
> lgtm, though make sure to test the suggested invocation from the root of
build, or some other wacky place.  Could we use the relative directory of the
current repo and print a CD command at the top? E.g.
> 
>   cd $(git rev-parse --show-toplevel)/$(git rev-parse --show-prefix)
>   python ./recipes.py .....
> 
> ?
> 
>
https://chromiumcodereview.appspot.com/1861203002/diff/60001/recipe_engine/ru...
> File recipe_engine/run.py (right):
> 
>
https://chromiumcodereview.appspot.com/1861203002/diff/60001/recipe_engine/ru...
> recipe_engine/run.py:228: '.', root_package.relative_recipes_dir,
'recipes.py'), recipe),
> I think there's a discrepancy between run_recipe and recipes.py; particularly,
run_recipe sets the CWD. Unless you fixed this some other way?

(I dunno if that incantation will WAI. It may be clearer to do it like:

  cd [REPO_ROOT]/path/to/relative/working_dir

)

[martiniss, 2016-07-21 18:34:13]

PTAL

[dsansome, 2016-07-28 06:33:14]

dsansome@chromium.org changed reviewers:
+ dsansome@chromium.org

[dsansome, 2016-07-28 06:33:15]

lgtm

https://codereview.chromium.org/1861203002/diff/80001/recipe_engine/run.py
File recipe_engine/run.py (right):

https://codereview.chromium.org/1861203002/diff/80001/recipe_engine/run.py#ne...
recipe_engine/run.py:236: '%s' % json.dumps(properties_to_print),
Remove the "'%s' % "?

[martiniss, 2016-08-08 22:15:47]

On 2016/07/28 at 06:33:15, dsansome wrote:
> lgtm
> 
> https://codereview.chromium.org/1861203002/diff/80001/recipe_engine/run.py
> File recipe_engine/run.py (right):
> 
>
https://codereview.chromium.org/1861203002/diff/80001/recipe_engine/run.py#ne...
> recipe_engine/run.py:236: '%s' % json.dumps(properties_to_print),
> Remove the "'%s' % "?

FTR, I'm stalled on testing this more in random places.

[iannucci, 2016-08-08 22:45:48]

On 2016/08/08 at 22:15:47, martiniss wrote:
> On 2016/07/28 at 06:33:15, dsansome wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/1861203002/diff/80001/recipe_engine/run.py
> > File recipe_engine/run.py (right):
> > 
> >
https://codereview.chromium.org/1861203002/diff/80001/recipe_engine/run.py#ne...
> > recipe_engine/run.py:236: '%s' % json.dumps(properties_to_print),
> > Remove the "'%s' % "?
> 
> FTR, I'm stalled on testing this more in random places.

I'm not sure what you mean by that?

[martiniss, 2016-08-08 23:24:40]

On 2016/08/08 at 22:45:48, iannucci wrote:
> On 2016/08/08 at 22:15:47, martiniss wrote:
> > On 2016/07/28 at 06:33:15, dsansome wrote:
> > > lgtm
> > > 
> > > https://codereview.chromium.org/1861203002/diff/80001/recipe_engine/run.py
> > > File recipe_engine/run.py (right):
> > > 
> > >
https://codereview.chromium.org/1861203002/diff/80001/recipe_engine/run.py#ne...
> > > recipe_engine/run.py:236: '%s' % json.dumps(properties_to_print),
> > > Remove the "'%s' % "?
> > 
> > FTR, I'm stalled on testing this more in random places.
> 
> I'm not sure what you mean by that?

I think it works but I want to try testing it in build, and make sure the
instructions make sense no matter where you run the original command.

[martiniss, 2016-08-11 02:11:07]

The CQ bit was checked by martiniss@chromium.org

[martiniss, 2016-08-11 02:11:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org, dsansome@chromium.org
Link to the patchset: https://codereview.chromium.org/1861203002/#ps100001
(title: "Fix test, remove unneeded description.")

[commit-bot: I haz the power, 2016-08-11 02:11:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 02:14:11]

Description was changed from

==========
Make recipes.py run give better messages.

BUG=
==========

to

==========
Make recipes.py run give better messages.

BUG=

Committed:
https://github.com/luci/recipes-py/commit/85dbcfb4d81379d40b4461436daa5264008...
==========

[commit-bot: I haz the power, 2016-08-11 02:14:12]

Committed patchset #6 (id:100001) as
https://github.com/luci/recipes-py/commit/85dbcfb4d81379d40b4461436daa5264008...