Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1861153002: Go system tests: Close proxy and stub at the end of a test. (Closed)

Created:
4 years, 8 months ago by rudominer
Modified:
4 years, 8 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Go system tests: Close proxy and stub at the end of a test. Fixes=#743 R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1f037be780abd8105e6eb82c88831be4dcfb4a8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M mojo/go/tests/regression_test.go View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rudominer
ptal
4 years, 8 months ago (2016-04-05 23:07:56 UTC) #3
viettrungluu
lgtm
4 years, 8 months ago (2016-04-05 23:13:18 UTC) #4
rudominer
4 years, 8 months ago (2016-04-05 23:14:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f037be780abd8105e6eb82c88831be4dcfb4a8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698