third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h - Issue 1861013005: bluetooth: Move GetCharacteristic(s) over to Mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h

Issue 1861013005: bluetooth: Move GetCharacteristic(s) over to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-separate-tests-read-value

Patch Set: Address palmer's comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/bluetooth/web_bluetooth_impl.cc ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h

index 10553a1c7d99c51c3850b12a4ce586d0da7a9051..e1b1a7409bad937a75e99e24c909d4e42926d4c8 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h

@@ -9,6 +9,7 @@

#include "bindings/modules/v8/UnionTypesModules.h"

#include "platform/heap/Handle.h"

#include "public/platform/modules/bluetooth/WebBluetoothRemoteGATTService.h"

+#include "public/platform/modules/bluetooth/web_bluetooth.mojom.h"

#include "wtf/OwnPtr.h"

#include "wtf/PassOwnPtr.h"

#include "wtf/text/WTFString.h"

@@ -45,11 +46,11 @@ public:

String uuid() { return m_webService->uuid; }

bool isPrimary() { return m_webService->isPrimary; }

ScriptPromise getCharacteristic(ScriptState*, const StringOrUnsignedLong& characteristic, ExceptionState&);

- ScriptPromise getCharacteristics(ScriptState*, ExceptionState&);

ScriptPromise getCharacteristics(ScriptState*, const StringOrUnsignedLong& characteristic, ExceptionState&);

+ ScriptPromise getCharacteristics(ScriptState*, ExceptionState&);

private:

- ScriptPromise getCharacteristicsImpl(ScriptState*, String characteristicUUID);

+ ScriptPromise getCharacteristicsImpl(ScriptState*, mojom::WebBluetoothGATTQueryQuantity, String characteristicUUID = String());

OwnPtr<WebBluetoothRemoteGATTService> m_webService;

};