bluetooth: Move GetCharacteristic(s) over to Mojo

third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module blink.mojom;
 
 // Errors that can occur during Web Bluetooth execution, which are transformed
 // to a DOMException in Source/modules/bluetooth/BluetoothError.cpp.
 //
 // These errors all produce constant message strings. If a particular message
@@ skipping 50 matching lines @@
   BLACKLISTED_WRITE,
   NOT_ALLOWED_TO_ACCESS_SERVICE,
   REQUEST_DEVICE_WITH_BLACKLISTED_UUID,
   REQUEST_DEVICE_FROM_CROSS_ORIGIN_IFRAME,
   REQUEST_DEVICE_WITHOUT_FRAME,
   // SyntaxError:
   // TODO(ortuno): Remove once we no longer use IPC.
   ENUM_MAX_VALUE = REQUEST_DEVICE_WITHOUT_FRAME,
 };
 
+struct WebBluetoothRemoteGATTCharacteristic {
+  string instance_id;
+  string? uuid;
+  uint32 properties;
+};
+
 // TODO(ortuno): Define Bluetooth Service.
 // https://crbug.com/508771
 
 // Web Bluetooth Interface that Blink can use to perform
 // Bluetooth GATT Operations on Bluetooth Devices.
 interface WebBluetoothService {
   // Sets the client for this WebBluetoothService. The service will notify the
   // client of device events e.g. when a Characteristic's value changes or when
   // a device disconnects.
   SetClient(associated WebBluetoothServiceClient client);
 
+  // Returns the Characteristics of a GATT Service with |service_instance_id|.
+  // If |single_characteristic| is true, only one characteristic will be
+  // returned.
+  RemoteServiceGetCharacteristics(
+    string service_instance_id,
+    bool single_characteristic,

[Jeffrey Yasskin, 2016/04/22 01:16:38]

We should make this an enum so the call sites are clearer than 'true' and
'false'.

[ortuno, 2016/04/25 15:29:45]

Done.

+    string? characteristics_uuid) => (

[Jeffrey Yasskin, 2016/04/22 01:16:38]

We should get this type-checked. I'm sorry for not noticing when it went into
bluetooth_messages.h, but that should have been a BluetoothUUID, not just a
string. IIRC, Mojo now has support for validators on particular arguments.

[ortuno, 2016/04/25 15:29:45]

No problem! I already noticed :) Yes, Mojo does have support but it's been
changing a lot lately so I've been advised to stay away from it until it
stabilizes a bit. I was planning on passing strings for now and once the move is
complete and typemaps are more stable I was going to replace all instances with
BluetoothUUID. Do you think that's acceptable? Otherwise I can start now, but
this patch will get slightly bigger.

[Jeffrey Yasskin, 2016/04/25 17:26:11]

Waiting sounds good.

[ortuno, 2016/04/25 20:37:41]

I opened an issue so that we don't forget.

+      WebBluetoothError error,
+      array<WebBluetoothRemoteGATTCharacteristic>? characteristics);
+
   // Reads the value for characteristic with
   // |characteristic_instance_id|. If the value is successfully read the
   // callback will be run with WebBluetoothError::SUCCESS and the
   // characteristic's value. If the value is not successfully read the
   // callback with be run with the corresponding error and nullptr for value.
   RemoteCharacteristicReadValue(
     string characteristic_instance_id) => (
     WebBluetoothError error,
     array<uint8>? value);
 
@@ skipping 16 matching lines @@
     string characteristic_instance_id) => ();
 };
 
 // Classes should implement this interface and pass an associated pointer
 // bound to them to the WebBluetoothService by using SetClient. Classes
 // that do this will be notified of device events e.g. device disconnection.
 interface WebBluetoothServiceClient {
   RemoteCharacteristicValueChanged(string characteristic_instance_id,
                                    array<uint8> value);
 };