Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

Issue 1861013004: AppListController refactoring part 3: Switching over to use AppListShower in Ash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mus_chrome_delegates_ash_impl
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/chrome_shell_delegate.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
index c9a0381b6b85f559d6f7f856fd9263adfbbad8fe..a017148538d7b297173ea68c7050d8d7a0e2b268 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
@@ -14,7 +14,6 @@
#include "ash/shelf/shelf_util.h"
#include "ash/shelf/shelf_view.h"
#include "ash/shell.h"
-#include "ash/test/app_list_controller_test_api.h"
#include "ash/test/shelf_test_api.h"
#include "ash/test/shelf_view_test_api.h"
#include "ash/test/shell_test_api.h"
@@ -33,6 +32,7 @@
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/app_list/app_list_service.h"
+#include "chrome/browser/ui/ash/app_list/test/app_list_service_ash_test_api.h"
#include "chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h"
#include "chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h"
#include "chrome/browser/ui/ash/launcher/launcher_item_controller.h"
@@ -126,10 +126,9 @@ void ClickAllAppsButtonFromStartPage(ui::test::EventGenerator* generator,
if (!app_list::switches::IsExperimentalAppListEnabled())
return;
- ash::test::AppListControllerTestApi controller_test(
- ash::Shell::GetInstance());
+ AppListServiceAshTestApi service_test;
- app_list::StartPageView* start_page_view = controller_test.GetStartPageView();
+ app_list::StartPageView* start_page_view = service_test.GetStartPageView();
DCHECK(start_page_view);
app_list::TileItemView* all_apps_button = start_page_view->all_apps_button();
@@ -140,7 +139,7 @@ void ClickAllAppsButtonFromStartPage(ui::test::EventGenerator* generator,
generator->ClickLeftButton();
base::MessageLoop::current()->RunUntilIdle();
// Run Layout() to effectively complete the animation to the apps page.
- controller_test.LayoutContentsView();
+ service_test.LayoutContentsView();
}
// Find the browser that associated with |app_name|.
@@ -1626,8 +1625,7 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, DISABLED_DragAndDrop) {
EXPECT_TRUE(service->IsAppListVisible());
app_list::AppsGridView* grid_view =
- ash::test::AppListControllerTestApi(ash::Shell::GetInstance()).
- GetRootGridView();
+ AppListServiceAshTestApi().GetRootGridView();
ASSERT_TRUE(grid_view);
ASSERT_TRUE(grid_view->has_drag_and_drop_host_for_test());
@@ -1781,8 +1779,7 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTestWithMultiMonitor,
EXPECT_TRUE(service->IsAppListVisible());
app_list::AppsGridView* grid_view =
- ash::test::AppListControllerTestApi(ash::Shell::GetInstance()).
- GetRootGridView();
+ AppListServiceAshTestApi().GetRootGridView();
ASSERT_TRUE(grid_view);
ASSERT_TRUE(grid_view->has_drag_and_drop_host_for_test());
@@ -1965,8 +1962,7 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, ClickItem) {
// Click an app icon in the app grid view.
app_list::AppsGridView* grid_view =
- ash::test::AppListControllerTestApi(ash::Shell::GetInstance()).
- GetRootGridView();
+ AppListServiceAshTestApi().GetRootGridView();
ASSERT_TRUE(grid_view);
const views::ViewModelT<app_list::AppListItemView>* vm_grid =
grid_view->view_model_for_test();
« no previous file with comments | « chrome/browser/ui/ash/chrome_shell_delegate.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698