Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(343)

Issue 18610: Remove ATL from wmi_util... (Closed)

Created:
10 years, 7 months ago by cpu_(ooo_6.6-7.5)
Modified:
8 years, 2 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove ATL from wmi_util - CComptr and CComBstr gone, baby gone - scoped_comptr_win.h file had a CRLF or at least VC thinks so - Future work: Grow variant helper class to be really helpful - Unit tests already exist It seems base is now free of ATL Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8419

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 11

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -42 lines) Patch
M base/scoped_comptr_win.h View 2 chunks +18 lines, -18 lines 0 comments Download
M base/wmi_util.cc View 1 2 3 chunks +50 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
10 years, 7 months ago (2009-01-21 04:08:02 UTC) #1
tommi (sloooow) - chröme
for some reason I'm not seeing the change to scoped_comptr_win.h http://codereview.chromium.org/18610/diff/202/7 File base/scoped_comptr_win.h (right): http://codereview.chromium.org/18610/diff/202/7#newcode5 ...
10 years, 7 months ago (2009-01-21 18:57:57 UTC) #2
tommi (sloooow) - chröme
LGTM with suggestions from my first reply reading the description told me why I wasn't ...
10 years, 7 months ago (2009-01-21 18:59:43 UTC) #3
cpu_(ooo_6.6-7.5)
10 years, 7 months ago (2009-01-21 20:27:52 UTC) #4
Thanks for the review. I'll commit in a few minutes.

Lets chat sometime about the next set of high impact atl replacements.

http://codereview.chromium.org/18610/diff/202/8
File base/wmi_util.cc (right):

http://codereview.chromium.org/18610/diff/202/8#newcode16
Line 16: class VariantHelper : public VARIANT {
On 2009/01/21 18:57:57, tommi wrote:
> nice... fyi, I've got a scoped_variant in the works, but will update this once
> that's complete.

Cool. I was hoping you wanted to :)  Added TODO(tommi) here.

http://codereview.chromium.org/18610/diff/202/8#newcode19
Line 19: ::VariantInit(this);
On 2009/01/21 18:57:57, tommi wrote:
> fyi - all VariantInit does is set vt = VT_EMPTY.  You could do that yourself
in
> the constructor to inline-enable it and avoid the function call

Done.

http://codereview.chromium.org/18610/diff/202/8#newcode22
Line 22: ::VariantInit(this);
On 2009/01/21 18:57:57, tommi wrote:
> VariantInit isn't necessary

Done.

http://codereview.chromium.org/18610/diff/202/8#newcode44
Line 44: NULL, 0, 0, wmi_services_r.Receive());
On 2009/01/21 18:57:57, tommi wrote:
> use StackBstr instead of ScopedBstr here

Done.

http://codereview.chromium.org/18610/diff/202/8#newcode125
Line 125: HRESULT hr = wmi_local->ExecMethod(ScopedBstr(class_name),
On 2009/01/21 18:57:57, tommi wrote:
> StackBstr for first two arguments

Done.

Powered by Google App Engine
This is Rietveld 408576698