Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1860953003: Call chrome.runtime.sendMessage's callback without arguments upon fail (Closed)

Created:
4 years, 8 months ago by robwu
Modified:
4 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call chrome.runtime.sendMessage's callback without arguments upon fail BUG=590949 Committed: https://crrev.com/ccb3bac625a150b6de7ed1855cfb3354f932792c Cr-Commit-Position: refs/heads/master@{#385346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M extensions/renderer/resources/messaging.js View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
robwu
See bug for details.
4 years, 8 months ago (2016-04-05 22:50:33 UTC) #2
Devlin
lgtm
4 years, 8 months ago (2016-04-05 22:53:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860953003/1
4 years, 8 months ago (2016-04-05 23:03:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/200054)
4 years, 8 months ago (2016-04-05 23:12:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860953003/1
4 years, 8 months ago (2016-04-05 23:14:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 00:23:16 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 00:25:22 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ccb3bac625a150b6de7ed1855cfb3354f932792c
Cr-Commit-Position: refs/heads/master@{#385346}

Powered by Google App Engine
This is Rietveld 408576698