Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 186093003: Remove platform/drm files. (Closed)

Created:
6 years, 9 months ago by jrummell
Modified:
6 years, 9 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove platform/drm files. The code in platform/drm contains minimal functionality now and can be removed. BUG=224791 TEST=EME content tests pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168464

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -344 lines) Patch
M Source/modules/encryptedmedia/MediaKeySession.h View 1 5 chunks +14 lines, -12 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 7 chunks +13 lines, -10 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.h View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
D Source/platform/drm/ContentDecryptionModule.h View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/platform/drm/ContentDecryptionModule.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/platform/drm/ContentDecryptionModuleSession.h View 1 chunk +0 lines, -85 lines 0 comments Download
D Source/platform/drm/ContentDecryptionModuleSession.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jrummell
PTAL.
6 years, 9 months ago (2014-03-03 21:01:05 UTC) #1
ddorwin
lgtm. one nit. https://codereview.chromium.org/186093003/diff/1/Source/modules/encryptedmedia/MediaKeySession.h File Source/modules/encryptedmedia/MediaKeySession.h (right): https://codereview.chromium.org/186093003/diff/1/Source/modules/encryptedmedia/MediaKeySession.h#newcode64 Source/modules/encryptedmedia/MediaKeySession.h:64: // it may outlive any references ...
6 years, 9 months ago (2014-03-04 00:16:37 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm https://codereview.chromium.org/186093003/diff/1/Source/modules/encryptedmedia/MediaKeySession.cpp File Source/modules/encryptedmedia/MediaKeySession.cpp (right): https://codereview.chromium.org/186093003/diff/1/Source/modules/encryptedmedia/MediaKeySession.cpp#newcode45 Source/modules/encryptedmedia/MediaKeySession.cpp:45: return adoptPtr(new PendingAction(Update, data)); nit: Put an ASSERT(data) ...
6 years, 9 months ago (2014-03-04 00:39:25 UTC) #3
jrummell
+abarth@ for OWNERS review. https://codereview.chromium.org/186093003/diff/1/Source/modules/encryptedmedia/MediaKeySession.cpp File Source/modules/encryptedmedia/MediaKeySession.cpp (right): https://codereview.chromium.org/186093003/diff/1/Source/modules/encryptedmedia/MediaKeySession.cpp#newcode45 Source/modules/encryptedmedia/MediaKeySession.cpp:45: return adoptPtr(new PendingAction(Update, data)); On ...
6 years, 9 months ago (2014-03-04 01:13:28 UTC) #4
abarth-chromium
rsLGTM
6 years, 9 months ago (2014-03-04 04:55:39 UTC) #5
jrummell
The CQ bit was checked by jrummell@chromium.org
6 years, 9 months ago (2014-03-04 17:16:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/186093003/20001
6 years, 9 months ago (2014-03-04 17:16:49 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 11:01:55 UTC) #8
Message was sent while issue was closed. 
Change committed as 168464

Powered by Google App Engine
This is Rietveld 408576698