Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1860883002: Introduce DCHECK() in expandToParagraphBoundary() (Closed)

Created:
4 years, 8 months ago by yosin_UTC9
Modified:
4 years, 8 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce DCHECK() in expandToParagraphBoundary() This patch introduces |DCHECK()| in |expandToParagraphBoundary()| to detect where we do wrong for ease of finding root cause. BUG=600378 TEST=n/a; no behavior changes Committed: https://crrev.com/3325b1d139dd5ce8101ed992c3038b5ddcca5513 Cr-Commit-Position: refs/heads/master@{#385368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
yosin_UTC9
PTAL
4 years, 8 months ago (2016-04-05 06:17:41 UTC) #3
yoichio
On 2016/04/05 06:17:41, Yosi_UTC9 wrote: > PTAL What's the different between ASSERT and DCHECK?
4 years, 8 months ago (2016-04-05 09:29:23 UTC) #4
yosin_UTC9
On 2016/04/05 at 09:29:23, yoichio wrote: > On 2016/04/05 06:17:41, Yosi_UTC9 wrote: > > PTAL ...
4 years, 8 months ago (2016-04-06 01:04:25 UTC) #5
yoichio
lgtm
4 years, 8 months ago (2016-04-06 01:42:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860883002/1
4 years, 8 months ago (2016-04-06 01:58:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 02:06:16 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 02:07:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3325b1d139dd5ce8101ed992c3038b5ddcca5513
Cr-Commit-Position: refs/heads/master@{#385368}

Powered by Google App Engine
This is Rietveld 408576698