Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1860823006: clang upload bot rename, src/ part (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
krasin1, Dirk Pranke, krasin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang upload bot rename, src/ part BUG=600465

Patch Set 1 #

Patch Set 2 : rebae #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/clang/scripts/upload_revision.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Nico
4 years, 8 months ago (2016-04-05 20:40:58 UTC) #2
krasin
LGTM assuming the patch issues are resolved.
4 years, 8 months ago (2016-04-05 20:47:15 UTC) #4
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-05 21:24:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860823006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860823006/20001
4 years, 8 months ago (2016-04-06 00:48:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/206188)
4 years, 8 months ago (2016-04-06 06:49:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860823006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860823006/20001
4 years, 8 months ago (2016-04-06 15:58:04 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/165238) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-06 16:02:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860823006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860823006/20001
4 years, 8 months ago (2016-04-06 18:17:13 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/165314)
4 years, 8 months ago (2016-04-06 18:22:30 UTC) #18
krasin
Nico, the patch fails to apply. Can you please sync it and submit the new ...
4 years, 8 months ago (2016-04-06 18:24:04 UTC) #19
Dirk Pranke
4 years, 8 months ago (2016-04-07 22:59:54 UTC) #20
On 2016/04/06 18:24:04, krasin wrote:
> Nico,
> 
> the patch fails to apply. Can you please sync it and submit the new revision,
> please?

I've posted a new version of this merged to HEAD in
https://codereview.chromium.org/1869943002/ .

Powered by Google App Engine
This is Rietveld 408576698