Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: cc/quads/draw_polygon_unittest.cc

Issue 1860823003: Enhance unit tests for normals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/quads/draw_polygon_unittest.cc
diff --git a/cc/quads/draw_polygon_unittest.cc b/cc/quads/draw_polygon_unittest.cc
index eb6d1625986bd19dc12683f1fcd234522a8e1266..041dc63250c839f81897945ada253fbab1c20df8 100644
--- a/cc/quads/draw_polygon_unittest.cc
+++ b/cc/quads/draw_polygon_unittest.cc
@@ -74,17 +74,6 @@ TEST(DrawPolygonConstructionTest, TestNormal) {
EXPECT_NORMAL(polygon, 0.0f, 0.0f, 1.0f);
}
-TEST(DrawPolygonConstructionTest, InverseNormal) {
- std::vector<gfx::Point3F> vertices;
- vertices.push_back(gfx::Point3F(0.0f, 10.0f, 0.0f));
- vertices.push_back(gfx::Point3F(10.0f, 10.0f, 0.0f));
- vertices.push_back(gfx::Point3F(10.0f, 0.0f, 0.0f));
- vertices.push_back(gfx::Point3F(0.0f, 0.0f, 0.0f));
-
- CREATE_TEST_DRAW_POLYGON(polygon, vertices, 1);
- EXPECT_NORMAL(polygon, 0.0f, 0.0f, -1.0f);
-}
-
TEST(DrawPolygonConstructionTest, ClippedNormal) {
std::vector<gfx::Point3F> vertices;
vertices.push_back(gfx::Point3F(0.1f, 10.0f, 0.0f));
@@ -125,28 +114,75 @@ TEST(DrawPolygonConstructionTest, ManyVertexNormal) {
}
// A simple rect being transformed.
-TEST(DrawPolygonConstructionTest, DizzyNormal) {
+TEST(DrawPolygonConstructionTest, SimpleNormal) {
gfx::RectF src(-0.1f, -10.0f, 0.2f, 20.0f);
gfx::Transform transform_i(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1);
DrawPolygon polygon_i(NULL, src, transform_i, 1);
EXPECT_NORMAL(polygon_i, 0.0f, 0.0f, 1.0f);
+}
- gfx::Transform tranform_a(0, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1);
- DrawPolygon polygon_a(NULL, src, tranform_a, 2);
- EXPECT_NORMAL(polygon_a, 0.0f, 0.0f, -1.0f);
+TEST(DrawPolygonConstructionTest, DISABLED_NormalInvertXY) {
+ gfx::RectF src(-0.1f, -10.0f, 0.2f, 20.0f);
+
+ gfx::Transform transform(0, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1);
+ DrawPolygon polygon_a(NULL, src, transform, 2);
+
+ EXPECT_NORMAL(polygon_a, 0.0f, 0.0f, 1.0f);
+}
+
+TEST(DrawPolygonConstructionTest, DISABLED_NormalInvertXZ) {
+ gfx::RectF src(-0.1f, -10.0f, 0.2f, 20.0f);
+
+ gfx::Transform transform(0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1);
+ DrawPolygon polygon_b(NULL, src, transform, 3);
- gfx::Transform tranform_b(0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1);
- DrawPolygon polygon_b(NULL, src, tranform_b, 3);
- EXPECT_NORMAL(polygon_b, -1.0f, 0.0f, 0.0f);
+ EXPECT_NORMAL(polygon_b, 1.0f, 0.0f, 0.0f);
+}
+
+TEST(DrawPolygonConstructionTest, DISABLED_NormalInvertYZ) {
+ gfx::RectF src(-0.1f, -10.0f, 0.2f, 20.0f);
+
+ gfx::Transform transform(1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1);
+ DrawPolygon polygon_c(NULL, src, transform, 4);
+
+ EXPECT_NORMAL(polygon_c, 0.0f, 1.0f, 0.0f);
+}
+
+TEST(DrawPolygonConstructionTest, NormalRotate90) {
+ gfx::RectF src(-0.1f, -10.0f, 0.2f, 20.0f);
+
+ gfx::Transform transform(0, -1, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 1);
+ DrawPolygon polygon_b(NULL, src, transform, 3);
+
+ EXPECT_NORMAL(polygon_b, 0.0f, 0.0f, 1.0f);
+}
+
+TEST(DrawPolygonConstructionTest, DISABLED_InvertXNormal) {
+ gfx::RectF src(-0.1f, -10.0f, 0.2f, 20.0f);
+
+ gfx::Transform transform(-1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1);
+ DrawPolygon polygon_d(NULL, src, transform, 5);
+
+ EXPECT_NORMAL(polygon_d, 0.0f, 0.0f, 1.0f);
+}
+
+TEST(DrawPolygonConstructionTest, DISABLED_InvertYNormal) {
+ gfx::RectF src(-0.1f, -10.0f, 0.2f, 20.0f);
+
+ gfx::Transform transform(1, 0, 0, 0, 0, -1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1);
+ DrawPolygon polygon_d(NULL, src, transform, 5);
+
+ EXPECT_NORMAL(polygon_d, 0.0f, 0.0f, 1.0f);
+}
+
+TEST(DrawPolygonConstructionTest, DISABLED_InvertZNormal) {
+ gfx::RectF src(-0.1f, -10.0f, 0.2f, 20.0f);
- gfx::Transform tranform_c(1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1);
- DrawPolygon polygon_c(NULL, src, tranform_c, 4);
- EXPECT_NORMAL(polygon_c, 0.0f, -1.0f, 0.0f);
+ gfx::Transform transform(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, -1, 0, 0, 0, 0, 1);
+ DrawPolygon polygon_d(NULL, src, transform, 5);
- gfx::Transform tranform_d(-1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1);
- DrawPolygon polygon_d(NULL, src, tranform_d, 5);
EXPECT_NORMAL(polygon_d, 0.0f, 0.0f, -1.0f);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698