PRESUBMIT.py - Issue 1860803003: Better error for checkdeps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1860803003: Better error for checkdeps. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 819c4e64fdcd2c4592c0332f61bd4c1141e1e165..68f92b6510ca10abfad7120a2ec9ec61f189cecc 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -50,6 +50,9 @@ def _CheckUnwantedDependencies(input_api, output_api):

import checkdeps

from cpp_checker import CppChecker

from rules import Rule

+ except ImportError:

+ return [output_api.PresubmitError(

+ 'Unable to run checkdeps, check pdfium/buildtools/checkdeps exists.')]

Tom Sepez 2016/04/05 16:42:02 nit: maybe "..., does pdfium/buildtools/checkdeps

dsinclair 2016/04/05 17:16:26 Done.

finally:

# Restore sys.path to what it was before.

sys.path = original_sys_path

« no previous file with comments | « no previous file | no next file » | no next file with comments »