Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1860803003: Better error for checkdeps. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, brucedawson
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Better error for checkdeps. If the checkdeps script can not be found the following error will be issued instead of a stacktrace: ** Presubmit ERRORS ** Unable to run checkdeps, does pdfium/buildtools/checkdeps exist? BUG=chromium:600043 Committed: https://pdfium.googlesource.com/pdfium/+/4cd49e1c6076bd9ef2d18480d893038822668262

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M PRESUBMIT.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-05 13:32:01 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1860803003/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/1860803003/diff/1/PRESUBMIT.py#newcode55 PRESUBMIT.py:55: 'Unable to run checkdeps, check pdfium/buildtools/checkdeps exists.')] nit: ...
4 years, 8 months ago (2016-04-05 16:42:02 UTC) #3
dsinclair
https://codereview.chromium.org/1860803003/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/1860803003/diff/1/PRESUBMIT.py#newcode55 PRESUBMIT.py:55: 'Unable to run checkdeps, check pdfium/buildtools/checkdeps exists.')] On 2016/04/05 ...
4 years, 8 months ago (2016-04-05 17:16:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860803003/20001
4 years, 8 months ago (2016-04-05 17:16:47 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 17:28:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/4cd49e1c6076bd9ef2d18480d89303882266...

Powered by Google App Engine
This is Rietveld 408576698