Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: chrome/browser/about_flags.cc

Issue 1860743002: Add a flag to change when android's progress bar completes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a bad merge Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index bade77bbbbdbc638c3d3e844ddcaa616d10b56dd..3a4eb6321e1f3b44413b101b920b0f2f51e8304b 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -461,6 +461,19 @@ const FeatureEntry::Choice kProgressBarAnimationChoices[] = {
{ IDS_FLAGS_PROGRESS_BAR_ANIMATION_FAST_START,
switches::kProgressBarAnimation, "fast-start" },
};
+
+const FeatureEntry::Choice kProgressBarCompletionChoices[] = {
+ {IDS_FLAGS_PROGRESS_BAR_COMPLETION_LOAD_EVENT,
+ switches::kProgressBarCompletion, "loadEvent"},
+ {IDS_FLAGS_PROGRESS_BAR_COMPLETION_RESOURCES_BEFORE_DCL,
+ switches::kProgressBarCompletion, "resourcesBeforeDOMContentLoaded"},
+ {IDS_FLAGS_PROGRESS_BAR_COMPLETION_DOM_CONTENT_LOADED,
+ switches::kProgressBarCompletion, "domContentLoaded"},
+ {IDS_FLAGS_PROGRESS_BAR_COMPLETION_RESOURCES_BEFORE_DCL_AND_SAME_ORIGIN_IFRAMES,
+ switches::kProgressBarCompletion,
+ "resourcesBeforeDOMContentLoadedAndSameOriginIFrames"},
+};
+
#endif // defined(OS_ANDROID)
#if defined(OS_CHROMEOS)
@@ -1625,6 +1638,9 @@ const FeatureEntry kFeatureEntries[] = {
{"progress-bar-animation", IDS_FLAGS_PROGRESS_BAR_ANIMATION_NAME,
IDS_FLAGS_PROGRESS_BAR_ANIMATION_DESCRIPTION, kOsAndroid,
MULTI_VALUE_TYPE(kProgressBarAnimationChoices)},
+ {"progress-bar-completion", IDS_FLAGS_PROGRESS_BAR_COMPLETION_NAME,
+ IDS_FLAGS_PROGRESS_BAR_COMPLETION_DESCRIPTION, kOsAndroid,
+ MULTI_VALUE_TYPE(kProgressBarCompletionChoices)},
#endif // defined(OS_ANDROID)
#if defined(OS_ANDROID)
{"tab-switcher-theme-colors", IDS_FLAGS_TAB_SWITCHER_THEME_COLORS_NAME,

Powered by Google App Engine
This is Rietveld 408576698