Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: chrome/browser/about_flags.cc

Issue 1860743002: Add a flag to change when android's progress bar completes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add flag to include same origin iframes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 726c286481d4ef1fd981b65369061521955e3822..3cf2a2692869d568ccc4b0d0fb7d3ffcfd914f7e 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -462,6 +462,19 @@ const FeatureEntry::Choice kProgressBarAnimationChoices[] = {
{ IDS_FLAGS_PROGRESS_BAR_ANIMATION_FAST_START,
switches::kProgressBarAnimation, "fast-start" },
};
+
+const FeatureEntry::Choice kProgressBarCompletionChoices[] = {
+ {IDS_FLAGS_PROGRESS_BAR_COMPLETION_LOAD_EVENT,
+ switches::kProgressBarCompletion, "loadEvent"},
+ {IDS_FLAGS_PROGRESS_BAR_COMPLETION_RESOURCES_BEFORE_DCL,
+ switches::kProgressBarCompletion, "resourcesBeforeDOMContentLoaded"},
+ {IDS_FLAGS_PROGRESS_BAR_COMPLETION_DOM_CONTENT_LOADED,
+ switches::kProgressBarCompletion, "domContentLoaded"},
+ {IDS_FLAGS_PROGRESS_BAR_COMPLETION_RESOURCES_BEFORE_DCL_AND_SAME_ORIGIN_IFRAMES,
+ switches::kProgressBarCompletion,
+ "resourcesBeforeDOMContentLoadedAndSameOriginIFrames"},
+};
+
#endif // defined(OS_ANDROID)
#if defined(OS_CHROMEOS)
@@ -1629,6 +1642,9 @@ const FeatureEntry kFeatureEntries[] = {
{"progress-bar-animation", IDS_FLAGS_PROGRESS_BAR_ANIMATION_NAME,
IDS_FLAGS_PROGRESS_BAR_ANIMATION_DESCRIPTION, kOsAndroid,
MULTI_VALUE_TYPE(kProgressBarAnimationChoices)},
+ {"progress-bar-completion", IDS_FLAGS_PROGRESS_BAR_COMPLETION_NAME,
+ IDS_FLAGS_PROGRESS_BAR_COMPLETION_DESCRIPTION, kOsAndroid,
+ MULTI_VALUE_TYPE(kProgressBarCompletionChoices)},
#endif // defined(OS_ANDROID)
#if defined(OS_ANDROID)
{"tab-switcher-theme-colors", IDS_FLAGS_TAB_SWITCHER_THEME_COLORS_NAME,

Powered by Google App Engine
This is Rietveld 408576698