Add a flag to change when android's progress bar completes

content/common/content_switches_internal.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/content_switches_internal.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
@@ skipping 59 matching lines @@
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   bool enabled =
       (command_line->HasSwitch(switches::kEnableUseZoomForDSF) ||
        use_zoom_for_dsf_enabled_by_default) &&
       command_line->GetSwitchValueASCII(
           switches::kEnableUseZoomForDSF) != "false";
 
   return enabled;
 }
 
+ProgressBarCompletionOptions GetProgressBarCompletionOptions() {
+#if defined(OS_ANDROID)
+  const base::CommandLine& command_line =
+      *base::CommandLine::ForCurrentProcess();
+  std::string progress_bar_completion =
+      command_line.GetSwitchValueASCII(switches::kProgressBarCompletion);
+  if (progress_bar_completion == "loadEvent")
+    return PROGRESS_BAR_COMPLETION_LOAD_EVENT;
+  if (progress_bar_completion == "dclAndImages")

[dcheng, 2016/05/10 06:28:50]

My main concern here is that it's not immediately obvious that dcl ==
"DOMContentLoaded"

[Nate Chapin, 2016/05/11 00:06:58]

I expanded the flag to domContentLoadedAndImages, but left
IDS_FLAGS_PROGRESS_BAR_COMPLETION_DCL_AND_IMAGES, is that OK?

+    return PROGRESS_BAR_COMPLETION_DOM_CONTENT_LOADED_AND_IMAGES;
+  if (progress_bar_completion == "domContentLoaded")
+    return PROGRESS_BAR_COMPLETION_DOM_CONTENT_LOADED;
+#endif
+  return PROGRESS_BAR_COMPLETION_LOAD_EVENT;
+}
+
 } // namespace content