Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1860723003: Handle bubble title resizing (growth) by reworking title layout (Closed)

Created:
4 years, 8 months ago by Evan Stade
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Handle bubble title resizing (growth) by reworking title layout The easiest way to demonstrate the bug is to shrink the browser window horizontally until the title starts to wrap, then drag it larger again. Without this patch, the title doesn't unwrap. I also noticed that one of the labels was jiggling in the collected cookies view during resize; left-aligning the text fixes that. BUG=598985 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/1849703004 Cr-Commit-Position: refs/heads/master@{#384722} (cherry picked from commit 63302b696824ab46a212de5bc1a1cf80b678a88a) Committed: https://chromium.googlesource.com/chromium/src/+/5d9c9aa306d3ba4e7feeeee8fabbca79034d00ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -29 lines) Patch
M chrome/browser/ui/views/collected_cookies_views.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 4 chunks +21 lines, -28 lines 0 comments Download
M ui/views/window/dialog_delegate_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
4 years, 8 months ago (2016-04-04 22:18:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d9c9aa306d3ba4e7feeeee8fabbca79034d00ac.

Powered by Google App Engine
This is Rietveld 408576698