Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 18607002: Format stack layout comments for X64 (Closed)

Created:
7 years, 5 months ago by haitao.feng
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Format stack layout comments for X64 R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -182 lines) Patch
M src/x64/builtins-x64.cc View 7 chunks +31 lines, -31 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 19 chunks +58 lines, -58 lines 0 comments Download
M src/x64/ic-x64.cc View 19 chunks +77 lines, -77 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 5 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
Formatted stack layout comments for X64. This makes those comments look consistent and will make ...
7 years, 5 months ago (2013-07-03 03:47:09 UTC) #1
Jakob Kummerow
LGTM, I'll land.
7 years, 5 months ago (2013-07-03 15:06:07 UTC) #2
Jakob Kummerow
7 years, 5 months ago (2013-07-03 15:36:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15481 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698